Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #12197 from t895/double-numeric-settings-fix
Android: Float slider settings fix
  • Loading branch information
JosJuice committed Sep 24, 2023
2 parents c67cd65 + fa37336 commit 117bfd3
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 32 deletions.
Expand Up @@ -2356,8 +2356,8 @@ class SettingsFragmentPresenter(
ceil(setting.getDoubleMin()).toFloat(),
floor(setting.getDoubleMax()).toFloat(),
setting.getUiSuffix(),
1.0f,
false
0.5f,
true
)
)

Expand Down
56 changes: 26 additions & 30 deletions Source/Android/app/src/main/res/layout/dialog_slider.xml
@@ -1,41 +1,37 @@
<?xml version="1.0" encoding="utf-8"?>
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<com.google.android.material.slider.Slider
android:id="@+id/slider"
android:layout_width="0dp"
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginStart="24dp"
app:layout_constraintEnd_toStartOf="@id/text_value"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
android:gravity="center"
android:layout_marginHorizontal="24dp"
android:layout_marginTop="24dp">

<TextView
android:id="@+id/text_value"
android:layout_width="40dp"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/spacing_medlarge"
android:gravity="end"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/text_units"
app:layout_constraintStart_toEndOf="@id/slider"
app:layout_constraintTop_toTopOf="parent"
tools:text="10000" />
<TextView
android:id="@+id/text_value"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:gravity="end"
tools:text="10000" />

<TextView
android:id="@+id/text_units"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
tools:text="%" />

<TextView
android:id="@+id/text_units"
android:layout_width="wrap_content"
</LinearLayout>

<com.google.android.material.slider.Slider
android:id="@+id/slider"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginEnd="24dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/text_value"
app:layout_constraintTop_toTopOf="parent"
tools:text="%" />
android:layout_marginHorizontal="24dp"
android:layout_marginBottom="24dp" />

</androidx.constraintlayout.widget.ConstraintLayout>
</LinearLayout>

0 comments on commit 117bfd3

Please sign in to comment.