Merge pull request #8716 from Pokechu22/properties-leak

Delete properties dialog on close
dolphin-emu · Apr 16, 2020 · 3629e75 · 3629e75
2 parents 744abab + e11a2bd
commit 3629e75
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/Source/Core/DolphinQt/GameList/GameList.cpp b/Source/Core/DolphinQt/GameList/GameList.cpp
@@ -431,6 +431,9 @@ void GameList::OpenProperties()
     return;
 
   PropertiesDialog* properties = new PropertiesDialog(this, *game);
+  // Since the properties dialog locks the game file, it's important to free it as soon as it's
+  // closed so that the file can be moved or deleted.
+  properties->setAttribute(Qt::WA_DeleteOnClose, true);
 
   connect(properties, &PropertiesDialog::OpenGeneralSettings, this, &GameList::OpenGeneralSettings);