Skip to content
Permalink
Browse files
Merge pull request #9386 from leoetlino/config-cache-invalidate
Config: Fix cache not being invalidated when callbacks are suppressed
  • Loading branch information
leoetlino committed Dec 29, 2020
2 parents 92de043 + 9ffd345 commit 3b2e312
Showing 1 changed file with 5 additions and 2 deletions.
@@ -71,11 +71,14 @@ void AddConfigChangedCallback(ConfigChangedCallback func)

void OnConfigChanged()
{
// Increment the config version to invalidate caches.
// To ensure that getters do not return stale data, this should always be done
// even when callbacks are suppressed.
s_config_version.fetch_add(1, std::memory_order_relaxed);

if (s_callback_guards)
return;

s_config_version.fetch_add(1, std::memory_order_relaxed);

for (const auto& callback : s_callbacks)
callback();
}

0 comments on commit 3b2e312

Please sign in to comment.