Skip to content
Permalink
Browse files

Fix 2 DTK bugs

Bug 1: subcommand 1 of 0xE1 does not actually reset the current position; it just stops playback.  0xE2 returns the same value it would have before stopping playback (other than reporting that the stream is stopped).

Bug 2: subcommand 3 of 0xE2 was incorrectly dividing the length by 4; while this makes sense for positions (which are multiplied by 4 earlier to get a byte offset), it is not correct for lengths.
  • Loading branch information...
Pokechu22 committed Sep 4, 2019
1 parent 828dc0f commit 3efa3d7a42babfef524438cdd31a0d5bd896edfd
Showing with 1 addition and 6 deletions.
  1. +1 −6 Source/Core/Core/HW/DVD/DVDInterface.cpp
@@ -991,11 +991,6 @@ void ExecuteCommand(u32 command_0, u32 command_1, u32 command_2, u32 output_addr
{
s_stop_at_track_end = false;
s_stream = false;
s_audio_position = 0;
s_next_start = 0;
s_next_length = 0;
s_current_start = 0;
s_current_length = 0;
}
else
{
@@ -1051,7 +1046,7 @@ void ExecuteCommand(u32 command_0, u32 command_1, u32 command_2, u32 output_addr
case 0x03: // Returns the total length
INFO_LOG(DVDINTERFACE, "(Audio): Stream Status: Request Audio status CurrentLength:%08x",
s_current_length);
WriteImmediate(static_cast<u32>(s_current_length >> 2), output_address, reply_to_ios);
WriteImmediate(s_current_length, output_address, reply_to_ios);
break;
default:
INFO_LOG(DVDINTERFACE, "(Audio): Subcommand: %02x Request Audio status %s",

0 comments on commit 3efa3d7

Please sign in to comment.
You can’t perform that action at this time.