Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #8783 from JosJuice/i18n-comments
DolphinQt: Add some i18n comments for recently added strings
  • Loading branch information
leoetlino committed May 2, 2020
2 parents c72b183 + 423241b commit 47d1dec
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Source/Core/DolphinQt/Debugger/NetworkWidget.cpp
Expand Up @@ -241,6 +241,7 @@ QGroupBox* NetworkWidget::CreateSocketTableGroup()
socket_table_group->setLayout(socket_table_layout);

m_socket_table = new QTableWidget();
// i18n: FD stands for file descriptor (and in this case refers to sockets, not regular files)
QStringList header{tr("FD"), tr("Domain"), tr("Type"), tr("State"), tr("Name")};
m_socket_table->setColumnCount(header.size());

Expand Down Expand Up @@ -286,6 +287,7 @@ QGroupBox* NetworkWidget::CreateSSLOptionsGroup()

m_dump_ssl_read_checkbox = new QCheckBox(tr("Dump SSL read"));
m_dump_ssl_write_checkbox = new QCheckBox(tr("Dump SSL write"));
// i18n: CA stands for certificate authority
m_dump_root_ca_checkbox = new QCheckBox(tr("Dump root CA"));
m_dump_peer_cert_checkbox = new QCheckBox(tr("Dump peer certificates"));
m_verify_certificates_checkbox = new QCheckBox(tr("Verify certificates"));
Expand Down
4 changes: 4 additions & 0 deletions Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp
Expand Up @@ -29,10 +29,14 @@ GCMemcardCreateNewDialog::GCMemcardCreateNewDialog(QWidget* parent) : QDialog(pa
m_combobox_size->setCurrentIndex(5);

m_radio_western = new QRadioButton(tr("Western (Windows-1252)"));
// i18n: The translation of this string should be consistent with the translation of the
// string "Western (Windows-1252)". Because of this, you may want to parse "Japanese" as
// "a character encoding which is from Japan / used in Japan" rather than "the Japanese language".
m_radio_shiftjis = new QRadioButton(tr("Japanese (Shift-JIS)"));
m_radio_western->setChecked(true);

auto* card_size_label = new QLabel(tr("Card Size"));
// i18n: Character encoding
auto* card_encoding_label = new QLabel(tr("Encoding"));
auto* button_box = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
button_box->button(QDialogButtonBox::Ok)->setText(tr("Create..."));
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/DolphinQt/Settings/AdvancedPane.cpp
Expand Up @@ -129,7 +129,7 @@ void AdvancedPane::CreateLayout()
auto* ram_override_description =
new QLabel(tr("Adjusts the emulated sizes of MEM1 and MEM2.\n\n"
"Some titles may recognize the larger memory arena(s) and take "
"advantage of it, though retail titles should be optimized for "
"advantage of it, though retail titles are normally optimized for "
"the retail memory limitations."));
ram_override_description->setWordWrap(true);
ram_override_layout->addWidget(ram_override_description);
Expand Down

0 comments on commit 47d1dec

Please sign in to comment.