Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #472 from Sonicadvance1/ARM-is-not-generic
Make it so ARMv7 isn't a generic target.
  • Loading branch information
Sonicadvance1 committed Jun 8, 2014
2 parents 489534b + 6e1d312 commit 4cfeeee
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 18 deletions.
2 changes: 0 additions & 2 deletions CMakeLists.txt
Expand Up @@ -151,8 +151,6 @@ if(NOT ENABLE_GENERIC)
set(_M_ARM 1)
set(_M_ARM_32 1)
add_definitions(-D_M_ARM=1 -D_M_ARM_32=1)
# ARMv7 isn't a generic build anymore, this shouldn't need to be defined
set(ENABLE_GENERIC 1)
if(${ANDROID_NDK_ABI_NAME} MATCHES "armeabi-v7a")
add_definitions(-marm -march=armv7-a)
endif()
Expand Down
21 changes: 10 additions & 11 deletions Source/Core/Common/CMakeLists.txt
Expand Up @@ -31,17 +31,16 @@ set(SRCS BreakPoints.cpp
if(_M_ARM_32) #ARMv7
set(SRCS ${SRCS}
ArmCPUDetect.cpp
ArmEmitter.cpp)
else()
if(_M_X86) #X86
set(SRCS ${SRCS}
x64FPURoundMode.cpp)
endif()
set(SRCS ${SRCS} x64CPUDetect.cpp)
endif()
if(_M_GENERIC) #Generic
set(SRCS ${SRCS}
GenericFPURoundMode.cpp)
ArmEmitter.cpp
GenericFPURoundMode.cpp)
elseif(_M_X86) #X86
set(SRCS ${SRCS}
x64CPUDetect.cpp
x64FPURoundMode.cpp)
else() #Generic
set(SRCS ${SRCS}
GenericFPURoundMode.cpp
x64CPUDetect.cpp)
endif()
if(WIN32)
set(SRCS ${SRCS} ExtendedTrace.cpp)
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/Common/CommonFuncs.h
Expand Up @@ -36,7 +36,7 @@ struct ArraySizeImpl : public std::extent<T>
#endif

#if (defined __GNUC__ && !__GNUC_PREREQ(4,9)) && \
!defined __SSSE3__ && !defined _M_GENERIC
!defined __SSSE3__ && defined _M_X86
#include <emmintrin.h>
static __inline __m128i __attribute__((__always_inline__))
_mm_shuffle_epi8(__m128i a, __m128i mask)
Expand All @@ -61,10 +61,10 @@ _mm_shuffle_epi8(__m128i a, __m128i mask)
// go to debugger mode
#ifdef GEKKO
#define Crash()
#elif defined _M_GENERIC
#define Crash() { exit(1); }
#else
#elif defined _M_X86
#define Crash() {asm ("int $3");}
#else
#define Crash() { exit(1); }
#endif

// GCC 4.8 defines all the rotate functions now
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/VideoCommon/CMakeLists.txt
Expand Up @@ -38,7 +38,7 @@ set(SRCS BPFunctions.cpp
XFStructs.cpp)
set(LIBS core png)

if(NOT _M_GENERIC)
if(_M_X86)
set(SRCS ${SRCS} TextureDecoder_x64.cpp)
else()
set(SRCS ${SRCS} TextureDecoder_Generic.cpp)
Expand Down

0 comments on commit 4cfeeee

Please sign in to comment.