Skip to content
Browse files

UICommon/ResourcePack/Manager: Resolve use-after-move in Add()

The pack is already has its validity checked at the beginning of the
function, so we don't need to check this again after inserting it.

Also resolves a use-after-move case.
  • Loading branch information...
lioncash committed May 28, 2019
1 parent 992c8bf commit 4d2e0c7b480eea2ec78377004ec6911c83abbfff
Showing with 1 addition and 1 deletion.
  1. +1 −1 Source/Core/UICommon/ResourcePack/Manager.cpp
@@ -128,7 +128,7 @@ bool Add(const std::string& path, int offset)

packs.insert(packs.begin() + offset, std::move(pack));

return pack.IsValid();
return true;

bool Remove(ResourcePack& pack)

0 comments on commit 4d2e0c7

Please sign in to comment.
You can’t perform that action at this time.