Skip to content
Permalink
Browse files

DiscIO/VolumeVerifier: Default destructor within the cpp file

Given the volume verifier has quite a few non-trivial object within it,
it's best to default the destructor within the cpp file to prevent
inlining complex destruction logic elsewhere, while also making it nicer
if a forward-declared type is ever used in a member variable.
  • Loading branch information...
lioncash committed May 27, 2019
1 parent 0ccaa2b commit 52eb2d0d826fddd2c0248ad753ee629419277936
Showing with 4 additions and 0 deletions.
  1. +2 −0 Source/Core/DiscIO/VolumeVerifier.cpp
  2. +2 −0 Source/Core/DiscIO/VolumeVerifier.h
@@ -54,6 +54,8 @@ VolumeVerifier::VolumeVerifier(const Volume& volume, Hashes<bool> hashes_to_calc
{
}

VolumeVerifier::~VolumeVerifier() = default;

void VolumeVerifier::Start()
{
ASSERT(!m_started);
@@ -72,6 +72,8 @@ class VolumeVerifier final
};

VolumeVerifier(const Volume& volume, Hashes<bool> hashes_to_calculate);
~VolumeVerifier();

void Start();
void Process();
u64 GetBytesProcessed() const;

0 comments on commit 52eb2d0

Please sign in to comment.
You can’t perform that action at this time.