Revert "[NetPlay] Make the Memory Card A/B setting sync across netplay."

This reverts commit e110f10. This unfixes issue 6575. Reverted due to huge performance hit on behalf of JMC.
dolphin-emu · Sep 4, 2013 · 5696da0 · 5696da0
1 parent d0d053a
commit 5696da0
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 19 deletions.
diff --git a/Source/Core/Core/Src/BootManager.cpp b/Source/Core/Core/Src/BootManager.cpp
@@ -46,7 +46,6 @@ struct ConfigCache
 	bool valid, bCPUThread, bSkipIdle, bEnableFPRF, bMMU, bDCBZOFF, m_EnableJIT, bDSPThread,
 		bVBeamSpeedHack, bSyncGPU, bFastDiscSpeed, bMergeBlocks, bDSPHLE, bHLE_BS2;
 	int iTLBHack, iCPUCore;
-	TEXIDevices m_EXIDevice[2];
 	std::string strBackend;
 };
 static ConfigCache config_cache;
@@ -95,8 +94,6 @@ bool BootCore(const std::string& _rFilename)
 		config_cache.bHLE_BS2 = StartUp.bHLE_BS2;
 		config_cache.m_EnableJIT = SConfig::GetInstance().m_EnableJIT;
 		config_cache.bDSPThread = StartUp.bDSPThread;
-		config_cache.m_EXIDevice[0] = SConfig::GetInstance().m_EXIDevice[0];
-		config_cache.m_EXIDevice[1] = SConfig::GetInstance().m_EXIDevice[1];
 
 		// General settings
 		game_ini.Get("Core", "CPUThread",			&StartUp.bCPUThread, StartUp.bCPUThread);
@@ -147,8 +144,6 @@ bool BootCore(const std::string& _rFilename)
 		StartUp.bDSPHLE = g_NetPlaySettings.m_DSPHLE;
 		StartUp.bEnableMemcardSaving = g_NetPlaySettings.m_WriteToMemcard;
 		SConfig::GetInstance().m_EnableJIT = g_NetPlaySettings.m_DSPEnableJIT;
-		SConfig::GetInstance().m_EXIDevice[0] = g_NetPlaySettings.m_EXIDevice[0];
-		SConfig::GetInstance().m_EXIDevice[1] = g_NetPlaySettings.m_EXIDevice[1];
 	}
 
 	// Run the game
@@ -189,8 +184,6 @@ void Stop()
 		VideoBackend::ActivateBackend(StartUp.m_strVideoBackend);
 		StartUp.bHLE_BS2 = config_cache.bHLE_BS2;
 		SConfig::GetInstance().m_EnableJIT = config_cache.m_EnableJIT;
-		SConfig::GetInstance().m_EXIDevice[0] = config_cache.m_EXIDevice[0];
-		SConfig::GetInstance().m_EXIDevice[1] = config_cache.m_EXIDevice[1];
 	}
 }
 

diff --git a/Source/Core/Core/Src/NetPlayClient.cpp b/Source/Core/Core/Src/NetPlayClient.cpp
@@ -237,11 +237,6 @@ unsigned int NetPlayClient::OnData(sf::Packet& packet)
 			packet >> g_NetPlaySettings.m_DSPEnableJIT;
 			packet >> g_NetPlaySettings.m_DSPHLE;
 			packet >> g_NetPlaySettings.m_WriteToMemcard;
-			int tmp;
-			packet >> tmp;
-			g_NetPlaySettings.m_EXIDevice[0] = (TEXIDevices) tmp;
-			packet >> tmp;
-			g_NetPlaySettings.m_EXIDevice[1] = (TEXIDevices) tmp;
 			}
 
 			m_dialog->OnMsgStartGame();

diff --git a/Source/Core/Core/Src/NetPlayProto.h b/Source/Core/Core/Src/NetPlayProto.h
@@ -7,15 +7,13 @@
 
 #include "Common.h"
 #include "CommonTypes.h"
-#include "HW/EXI_Device.h"
 
 struct NetSettings
 {
 	bool m_CPUthread;
 	bool m_DSPHLE;
 	bool m_DSPEnableJIT;
 	bool m_WriteToMemcard;
-	TEXIDevices m_EXIDevice[2];
 };
 
 struct Rpt : public std::vector<u8>
@@ -25,7 +23,7 @@ struct Rpt : public std::vector<u8>
 
 typedef std::vector<Rpt>	NetWiimote;
 
-#define NETPLAY_VERSION		"Dolphin NetPlay 2013-09-03"
+#define NETPLAY_VERSION		"Dolphin NetPlay 2013-08-31"
 
 // messages
 enum

diff --git a/Source/Core/Core/Src/NetPlayServer.cpp b/Source/Core/Core/Src/NetPlayServer.cpp
@@ -455,8 +455,6 @@ bool NetPlayServer::StartGame(const std::string &path)
 	spac << m_settings.m_DSPEnableJIT;
 	spac << m_settings.m_DSPHLE;
 	spac << m_settings.m_WriteToMemcard;
-	spac << m_settings.m_EXIDevice[0];
-	spac << m_settings.m_EXIDevice[1];
 
 	std::lock_guard<std::recursive_mutex> lkp(m_crit.players);
 	std::lock_guard<std::recursive_mutex> lks(m_crit.send);

diff --git a/Source/Core/DolphinWX/Src/NetWindow.cpp b/Source/Core/DolphinWX/Src/NetWindow.cpp
@@ -408,8 +408,6 @@ void NetPlayDiag::GetNetSettings(NetSettings &settings)
 	settings.m_DSPHLE = instance.m_LocalCoreStartupParameter.bDSPHLE;
 	settings.m_DSPEnableJIT = instance.m_EnableJIT;
 	settings.m_WriteToMemcard = m_memcard_write->GetValue();
-	settings.m_EXIDevice[0] = instance.m_EXIDevice[0];
-	settings.m_EXIDevice[1] = instance.m_EXIDevice[1];
 }
 
 std::string NetPlayDiag::FindGame()