Skip to content
Permalink
Browse files

VideoCommon/RenderBase: Reset scissor rectangle after ImGui rendering

This fixes the problem where OBS game capture only grabs the region
inside an ImGui window whenever one is open, when using the OpenGL
backend. Shouldn't have any negative effects, as the scissor would've
been something completely arbitrary anyways.

This may affect other capture software that uses the same hooking
method, but I've only tested OBS.
  • Loading branch information...
Techjar committed Jun 15, 2019
1 parent c34388f commit 56c818b3d86507a2653ddbe939ce9c241d77c855
Showing with 9 additions and 0 deletions.
  1. +9 −0 Source/Core/VideoCommon/RenderBase.cpp
@@ -1148,6 +1148,15 @@ void Renderer::DrawImGui()
base_index += cmd.ElemCount;
}
}

// Some capture software (such as OBS) hooks SwapBuffers and uses glBlitFramebuffer to copy our
// back buffer just before swap. Because glBlitFramebuffer honors the scissor test, the capture
// itself will be clipped to whatever bounds were last set by ImGui, resulting in a rather useless
// capture whenever any ImGui windows are open. We'll reset the scissor rectangle to the entire
// viewport here to avoid this problem.
SetScissorRect(ConvertFramebufferRectangle(
MathUtil::Rectangle<int>(0, 0, m_backbuffer_width, m_backbuffer_height),
m_current_framebuffer));
}

std::unique_lock<std::mutex> Renderer::GetImGuiLock()

0 comments on commit 56c818b

Please sign in to comment.
You can’t perform that action at this time.