Common/Analytics: std::move std::string constructor parameter

Allows calling code to move into the constructor, avoiding the creation of another string copy.
dolphin-emu · Jun 4, 2019 · 58e2cd5 · 58e2cd5
1 parent f813c49
commit 58e2cd5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Source/Core/Common/Analytics.cpp b/Source/Core/Common/Analytics.cpp
@@ -198,7 +198,7 @@ void StdoutAnalyticsBackend::Send(std::string report)
          HexDump(reinterpret_cast<const u8*>(report.data()), report.size()).c_str());
 }
 
-HttpAnalyticsBackend::HttpAnalyticsBackend(const std::string& endpoint) : m_endpoint(endpoint)
+HttpAnalyticsBackend::HttpAnalyticsBackend(std::string endpoint) : m_endpoint(std::move(endpoint))
 {
 }
 

diff --git a/Source/Core/Common/Analytics.h b/Source/Core/Common/Analytics.h
@@ -184,7 +184,7 @@ class StdoutAnalyticsBackend : public AnalyticsReportingBackend
 class HttpAnalyticsBackend : public AnalyticsReportingBackend
 {
 public:
-  HttpAnalyticsBackend(const std::string& endpoint);
+  explicit HttpAnalyticsBackend(std::string endpoint);
   ~HttpAnalyticsBackend() override;
 
   void Send(std::string report) override;