From 58e2cd54866572b48e422733b3112c58f7cce3a7 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 3 Jun 2019 18:33:02 -0400 Subject: [PATCH] Common/Analytics: std::move std::string constructor parameter Allows calling code to move into the constructor, avoiding the creation of another string copy. --- Source/Core/Common/Analytics.cpp | 2 +- Source/Core/Common/Analytics.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/Common/Analytics.cpp b/Source/Core/Common/Analytics.cpp index 4441e9a7dfde..ed48d1518849 100644 --- a/Source/Core/Common/Analytics.cpp +++ b/Source/Core/Common/Analytics.cpp @@ -198,7 +198,7 @@ void StdoutAnalyticsBackend::Send(std::string report) HexDump(reinterpret_cast(report.data()), report.size()).c_str()); } -HttpAnalyticsBackend::HttpAnalyticsBackend(const std::string& endpoint) : m_endpoint(endpoint) +HttpAnalyticsBackend::HttpAnalyticsBackend(std::string endpoint) : m_endpoint(std::move(endpoint)) { } diff --git a/Source/Core/Common/Analytics.h b/Source/Core/Common/Analytics.h index 45245ea42e46..dc1ab8c599a6 100644 --- a/Source/Core/Common/Analytics.h +++ b/Source/Core/Common/Analytics.h @@ -184,7 +184,7 @@ class StdoutAnalyticsBackend : public AnalyticsReportingBackend class HttpAnalyticsBackend : public AnalyticsReportingBackend { public: - HttpAnalyticsBackend(const std::string& endpoint); + explicit HttpAnalyticsBackend(std::string endpoint); ~HttpAnalyticsBackend() override; void Send(std::string report) override;