Merge pull request #9009 from JosJuice/android-settings-recreation

Android: Fix SettingsActivity lifecycle management
dolphin-emu · Aug 6, 2020 · 5ec65a2 · 5ec65a2
2 parents d8c0344 + 05e49b1
commit 5ec65a2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 48 deletions.
diff --git a/...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java b/...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java
@@ -111,16 +111,13 @@ protected void onStop()
     mPresenter.onStop(isFinishing());
   }
 
-  @Override
-  public void onBackPressed()
-  {
-    mPresenter.onBackPressed();
-  }
-
   @Override
   public void showSettingsFragment(MenuTag menuTag, Bundle extras, boolean addToStack,
           String gameID)
   {
+    if (!addToStack && getFragment() != null)
+      return;
+
     FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
 
     if (addToStack)
@@ -135,7 +132,6 @@ public void showSettingsFragment(MenuTag menuTag, Bundle extras, boolean addToSt
       }
 
       transaction.addToBackStack(null);
-      mPresenter.addToStack();
     }
     transaction.replace(R.id.frame_content, SettingsFragment.newInstance(menuTag, gameID, extras),
             FRAGMENT_TAG);
@@ -277,12 +273,6 @@ public void showToastMessage(String message)
     Toast.makeText(this, message, Toast.LENGTH_SHORT).show();
   }
 
-  @Override
-  public void popBackStack()
-  {
-    getSupportFragmentManager().popBackStackImmediate();
-  }
-
   @Override
   public void onSettingChanged(String key)
   {

diff --git a/...c/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java b/...c/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java
@@ -23,8 +23,6 @@
 
   private Settings mSettings;
 
-  private int mStackCount;
-
   private boolean mShouldSave;
 
   private DirectoryStateReceiver directoryStateReceiver;
@@ -43,16 +41,11 @@
 
   public void onCreate(Bundle savedInstanceState, MenuTag menuTag, String gameId, Context context)
   {
-    if (savedInstanceState == null)
-    {
-      this.menuTag = menuTag;
-      this.gameId = gameId;
-      this.context = context;
-    }
-    else
-    {
-      mShouldSave = savedInstanceState.getBoolean(KEY_SHOULD_SAVE);
-    }
+    this.menuTag = menuTag;
+    this.gameId = gameId;
+    this.context = context;
+
+    mShouldSave = savedInstanceState != null && savedInstanceState.getBoolean(KEY_SHOULD_SAVE);
   }
 
   public void onStart()
@@ -148,24 +141,6 @@ public void onStop(boolean finishing)
     }
   }
 
-  public void addToStack()
-  {
-    mStackCount++;
-  }
-
-  public void onBackPressed()
-  {
-    if (mStackCount > 0)
-    {
-      mView.popBackStack();
-      mStackCount--;
-    }
-    else
-    {
-      mView.finish();
-    }
-  }
-
   public boolean handleOptionsItem(int itemId)
   {
     switch (itemId)

diff --git a/...pp/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java b/...pp/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java
@@ -47,11 +47,6 @@
    */
   void showToastMessage(String message);
 
-  /**
-   * Show the previous fragment.
-   */
-  void popBackStack();
-
   /**
    * End the activity.
    */