Skip to content
Permalink
Browse files

Common/x64Emitter: Resolve TODO in OpArg's operator==

We now require C++17, so we can use std::tie here.
  • Loading branch information...
lioncash committed May 30, 2019
1 parent 00ecfb3 commit 66596c5176a9dc0ba7f20a94454e4007d63f1145
Showing with 2 additions and 4 deletions.
  1. +2 −4 Source/Core/Common/x64Emitter.h
@@ -120,10 +120,8 @@ struct OpArg
}
constexpr bool operator==(const OpArg& b) const
{
// TODO: Use std::tie here once Dolphin requires C++17. (We can't do it immediately,
// (because we still support some older versions of GCC where std::tie is not constexpr.)
return operandReg == b.operandReg && scale == b.scale && offsetOrBaseReg == b.offsetOrBaseReg &&
indexReg == b.indexReg && offset == b.offset;
return std::tie(scale, offsetOrBaseReg, indexReg, offset, operandReg) ==
std::tie(b.scale, b.offsetOrBaseReg, b.indexReg, b.offset, b.operandReg);
}
constexpr bool operator!=(const OpArg& b) const { return !operator==(b); }
u64 Imm64() const

0 comments on commit 66596c5

Please sign in to comment.
You can’t perform that action at this time.