Permalink
Browse files

Gekko: Make UReg_FPSCR's single argument constructor explicit

Prevent implicit conversions to UReg_FPSCR. Given the semantics of a
random magic value and the FPSCR are different, make explicit
conversions a requirement to signify intent.
  • Loading branch information...
lioncash committed May 6, 2018
1 parent cb5926c commit 69a0aaebd4819da6599560fd391d6e6bc2996e9d
Showing with 2 additions and 2 deletions.
  1. +1 −1 Source/Core/Core/PowerPC/Gekko.h
  2. +1 −1 Source/Core/Core/PowerPC/PowerPC.cpp
@@ -475,7 +475,7 @@ union UReg_FPSCR
u32 Hex = 0;
UReg_FPSCR() = default;
UReg_FPSCR(u32 hex_) : Hex{hex_} {}
explicit UReg_FPSCR(u32 hex_) : Hex{hex_} {}
};
// Hardware Implementation-Dependent Register 0
@@ -128,7 +128,7 @@ static void ResetRegisters()
ppcState.spr[SPR_ECID_M] = 0x1840c00d;
ppcState.spr[SPR_ECID_L] = 0x82bb08e8;
ppcState.fpscr = 0;
ppcState.fpscr.Hex = 0;
ppcState.pc = 0;
ppcState.npc = 0;
ppcState.Exceptions = 0;

0 comments on commit 69a0aae

Please sign in to comment.