Merge pull request #9141 from Techjar/but-for-how-long

Re-enable GPU Texture Decoding under MoltenVK
dolphin-emu · Oct 29, 2020 · 6a3a71c · 6a3a71c
2 parents f5eb40a + 0c01712
commit 6a3a71c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp b/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp
@@ -346,10 +346,6 @@ void VulkanContext::PopulateBackendInfoFeatures(VideoConfig* config, VkPhysicalD
   // with depth clamping. Fall back to inverted depth range for these.
   if (DriverDetails::HasBug(DriverDetails::BUG_BROKEN_REVERSED_DEPTH_RANGE))
     config->backend_info.bSupportsReversedDepthRange = false;
-
-  // GPU Texture Decoding is broken under MoltenVK.
-  if (DriverDetails::HasBug(DriverDetails::BUG_BROKEN_GPU_TEXTURE_DECODING))
-    config->backend_info.bSupportsGPUTextureDecoding = false;
 }
 
 void VulkanContext::PopulateBackendInfoMultisampleModes(

diff --git a/Source/Core/VideoCommon/DriverDetails.cpp b/Source/Core/VideoCommon/DriverDetails.cpp
@@ -118,8 +118,6 @@ constexpr BugInfo m_known_bugs[] = {
      -1.0, -1.0, true},
     {API_VULKAN, OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM, Family::UNKNOWN,
      BUG_SLOW_CACHED_READBACK_MEMORY, -1.0, -1.0, true},
-    {API_VULKAN, OS_OSX, VENDOR_ALL, DRIVER_PORTABILITY, Family::UNKNOWN,
-     BUG_BROKEN_GPU_TEXTURE_DECODING, -1.0, -1.0, true},
 };
 
 static std::map<Bug, BugInfo> m_bugs;

diff --git a/Source/Core/VideoCommon/DriverDetails.h b/Source/Core/VideoCommon/DriverDetails.h
@@ -286,10 +286,6 @@ enum Bug
   // Mali Vulkan driver, causing high CPU usage in the __pi___inval_cache_range kernel
   // function. This flag causes readback buffers to select the coherent type.
   BUG_SLOW_CACHED_READBACK_MEMORY,
-
-  // BUG: GPU Texture Decoding produces a spectacular mess or just outright crashes when using
-  // Vulkan on macOS through MoltenVK.
-  BUG_BROKEN_GPU_TEXTURE_DECODING,
 };
 
 // Initializes our internal vendor, device family, and driver version