Permalink
Browse files

SymbolDB: Default constructor and destructor within the cpp file

Given this is a class with non-trivial data-members, it's preferable to
default the constructor and destructor in the cpp file.
  • Loading branch information...
lioncash committed May 27, 2018
1 parent a1a81c7 commit 72e8058fb8221cadd9595ed3b4c08f41c52e0ebf
Showing with 7 additions and 2 deletions.
  1. +4 −0 Source/Core/Common/SymbolDB.cpp
  2. +3 −2 Source/Core/Common/SymbolDB.h
@@ -20,6 +20,10 @@ static std::string GetStrippedFunctionName(const std::string& symbol_name)
return name;
}
SymbolDB::SymbolDB() = default;
SymbolDB::~SymbolDB() = default;
void Symbol::Rename(const std::string& symbol_name)
{
this->name = symbol_name;
@@ -62,8 +62,9 @@ class SymbolDB
using XFuncMap = std::map<u32, Symbol>;
using XFuncPtrMap = std::map<u32, std::set<Symbol*>>;
SymbolDB() {}
virtual ~SymbolDB() {}
SymbolDB();
virtual ~SymbolDB();
virtual Symbol* GetSymbolFromAddr(u32 addr) { return nullptr; }
virtual Symbol* AddFunction(u32 start_addr) { return nullptr; }
void AddCompleteSymbol(const Symbol& symbol);

0 comments on commit 72e8058

Please sign in to comment.