Merge pull request #8680 from Leseratte10/master

SettingsHandler: Always decode the whole settings.txt file
dolphin-emu · Mar 23, 2020 · 76b97a4 · 76b97a4
2 parents aee9c73 + cba4acc
commit 76b97a4
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/Source/Core/Common/SettingsHandler.cpp b/Source/Core/Common/SettingsHandler.cpp
@@ -71,10 +71,8 @@ std::string SettingsHandler::GetValue(std::string_view key) const
 void SettingsHandler::Decrypt()
 {
   const u8* str = m_buffer.data();
-  while (*str != 0)
+  while (m_position < m_buffer.size())
   {
-    if (m_position >= m_buffer.size())
-      return;
     decoded.push_back((u8)(m_buffer[m_position] ^ m_key));
     m_position++;
     str++;