Skip to content
Permalink
Browse files

Merge pull request #7898 from spycrab/qt_netplay_empty_chat

Qt/NetPlayDialog: Prevent players from sending empty chat messages
  • Loading branch information...
JMC47 committed Mar 16, 2019
2 parents a40b5f9 + e64b6d2 commit 7acefe8a289e691517412a7b79ef3bbfd1acb26d
Showing with 8 additions and 0 deletions.
  1. +8 −0 Source/Core/DolphinQt/NetPlay/NetPlayDialog.cpp
@@ -210,6 +210,8 @@ void NetPlayDialog::CreateChatLayout()
m_chat_type_edit = new QLineEdit;
m_chat_send_button = new QPushButton(tr("Send"));

// This button will get re-enabled when something gets entered into the chat box
m_chat_send_button->setEnabled(false);
m_chat_send_button->setDefault(false);
m_chat_send_button->setAutoDefault(false);

@@ -285,6 +287,8 @@ void NetPlayDialog::ConnectWidgets()
// Chat
connect(m_chat_send_button, &QPushButton::clicked, this, &NetPlayDialog::OnChat);
connect(m_chat_type_edit, &QLineEdit::returnPressed, this, &NetPlayDialog::OnChat);
connect(m_chat_type_edit, &QLineEdit::textChanged, this,
[this] { m_chat_send_button->setEnabled(!m_chat_type_edit->text().isEmpty()); });

// Other
connect(m_buffer_size_box, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
@@ -355,6 +359,10 @@ void NetPlayDialog::OnChat()
{
QueueOnObject(this, [this] {
auto msg = m_chat_type_edit->text().toStdString();

if (msg.empty())
return;

Settings::Instance().GetNetPlayClient()->SendChatMessage(msg);
m_chat_type_edit->clear();

0 comments on commit 7acefe8

Please sign in to comment.
You can’t perform that action at this time.