Merge pull request #11174 from AdmiralCurtiss/news-channel-fix

IOS/NetKDRequest: Don't abort on first unset bit in subtask mask.
dolphin-emu · Oct 16, 2022 · 892ab87 · 892ab87
2 parents 02abc08 + 9992a19
commit 892ab87
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/Source/Core/Core/IOS/Network/KD/NetKDRequest.cpp b/Source/Core/Core/IOS/Network/KD/NetKDRequest.cpp
@@ -267,17 +267,14 @@ IPCReply NetKDRequestDevice::HandleNWC24DownloadNowEx(const IOCtlRequest& reques
   {
     for (u8 subtask_id = 0; subtask_id < 32; subtask_id++)
     {
-      // Check if we are done
-      if (!Common::ExtractBit(subtask_bitmask, subtask_id))
+      if (Common::ExtractBit(subtask_bitmask, subtask_id))
       {
-        break;
-      }
-
-      reply = KDDownload(entry_index, subtask_id);
-      if (reply != NWC24::WC24_OK)
-      {
-        // An error has occurred, break out and return error.
-        break;
+        reply = KDDownload(entry_index, subtask_id);
+        if (reply != NWC24::WC24_OK)
+        {
+          // An error has occurred, break out and return error.
+          break;
+        }
       }
     }
   }