Skip to content
Permalink
Browse files

UICommon/GameFile: Default no-arg constructor and destructor within t…

…he cpp file

A GameFile instance contains quite a lot of non-trivial types, so
default construction and destruction in the same translation unit.
  • Loading branch information...
lioncash committed May 28, 2019
1 parent 49ca314 commit 8e65869484c5b399f76b08e7717db80e6d7ed553
Showing with 6 additions and 2 deletions.
  1. +4 −0 Source/Core/UICommon/GameFile.cpp
  2. +2 −2 Source/Core/UICommon/GameFile.h
@@ -111,6 +111,8 @@ GameFile::LookupUsingConfigLanguage(const std::map<DiscIO::Language, std::string
return Lookup(GetConfigLanguage(), strings);
}

GameFile::GameFile() = default;

GameFile::GameFile(const std::string& path) : m_file_path(path)
{
{
@@ -159,6 +161,8 @@ GameFile::GameFile(const std::string& path) : m_file_path(path)
}
}

GameFile::~GameFile() = default;

bool GameFile::IsValid() const
{
if (!m_valid)
@@ -44,9 +44,9 @@ bool operator!=(const GameBanner& lhs, const GameBanner& rhs);
class GameFile final
{
public:
GameFile() = default;
GameFile();
explicit GameFile(const std::string& path);
~GameFile() = default;
~GameFile();

bool IsValid() const;
const std::string& GetFilePath() const { return m_file_path; }

0 comments on commit 8e65869

Please sign in to comment.
You can’t perform that action at this time.