Merge pull request #514 from jordan-woyak/input-diag-win-crash

Fix InputConfigDiag crash on Windows. (GCode issue 7384)
dolphin-emu · Jun 20, 2014 · 91502b4 · 91502b4
2 parents d62ae92 + 7ecc32f
commit 91502b4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Source/Core/DolphinWX/InputConfigDiag.cpp b/Source/Core/DolphinWX/InputConfigDiag.cpp
@@ -512,8 +512,8 @@ void ControlDialog::DetectControl(wxCommandEvent& event)
 	{
 		btn->SetLabel(_("[ waiting ]"));
 
-		// apparently, this makes the "waiting" text work on Linux
-		wxTheApp->Yield();
+		// This makes the "waiting" text work on Linux. true (only if needed) prevents crash on Windows
+		wxTheApp->Yield(true);
 
 		std::lock_guard<std::recursive_mutex> lk(m_plugin.controls_lock);
 		Device::Control* const ctrl = control_reference->Detect(DETECT_WAIT_TIME, dev);
@@ -536,8 +536,8 @@ void GamepadPage::DetectControl(wxCommandEvent& event)
 	{
 		btn->SetLabel(_("[ waiting ]"));
 
-		// apparently, this makes the "waiting" text work on Linux
-		wxTheApp->Yield();
+		// This makes the "waiting" text work on Linux. true (only if needed) prevents crash on Windows
+		wxTheApp->Yield(true);
 
 		std::lock_guard<std::recursive_mutex> lk(m_plugin.controls_lock);
 		Device::Control* const ctrl = btn->control_reference->Detect(DETECT_WAIT_TIME, dev);