Merge pull request #10721 from Dentomologist/fix_warnings_on_generic_…

…builder Fix warnings on generic builder
dolphin-emu · Jun 4, 2022 · 96f9d10 · 96f9d10
2 parents d7cda67 + 92af703
commit 96f9d10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Source/Core/Core/DSP/DSPAssembler.cpp b/Source/Core/Core/DSP/DSPAssembler.cpp
@@ -584,7 +584,6 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t
             }
           }
           break;
-
         case P_ACCL:
           if ((int)par[i].val < DSP_REG_ACL0 || (int)par[i].val > DSP_REG_ACL1)
           {
@@ -602,6 +601,8 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t
             }
           }
           break;
+        default:
+          break;
         }
         continue;
       }

diff --git a/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp b/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp
@@ -93,7 +93,7 @@ TEST(FileSystem, PathSplitting)
 
 TEST_F(FileSystemTest, EssentialDirectories)
 {
-  for (const std::string& path :
+  for (const std::string path :
        {"/sys", "/ticket", "/title", "/shared1", "/shared2", "/tmp", "/import", "/meta"})
   {
     EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()) << path;
@@ -457,7 +457,7 @@ TEST_F(FileSystemTest, CreateFullPath)
   ASSERT_EQ(m_fs->CreateFullPath(Uid{0}, Gid{0}, "/tmp/a/b/c/d", 0, modes), ResultCode::Success);
 
   // Parent directories should be created by CreateFullPath.
-  for (const std::string& path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"})
+  for (const std::string path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"})
     EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded());
 
   // If parent directories already exist, the call should still succeed.