Merge pull request #5897 from ligfx/netplayremovegoto

NetPlayServer: remove goto statements
dolphin-emu · Aug 7, 2017 · 9e51a7f · 9e51a7f
2 parents dbb26a2 + 2abf13a
commit 9e51a7f
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/Source/Core/Core/NetPlayServer.cpp b/Source/Core/Core/NetPlayServer.cpp
@@ -959,17 +959,15 @@ void NetPlayServer::TryPortmapping(u16 port)
 void NetPlayServer::mapPortThread(const u16 port)
 {
   if (!m_upnp_inited)
-    if (!initUPnP())
-      goto fail;
+    initUPnP();
 
-  if (!UPnPMapPort(m_upnp_ourip, port))
-    goto fail;
+  if (m_upnp_inited && UPnPMapPort(m_upnp_ourip, port))
+  {
+    NOTICE_LOG(NETPLAY, "Successfully mapped port %d to %s.", port, m_upnp_ourip.c_str());
+    return;
+  }
 
-  NOTICE_LOG(NETPLAY, "Successfully mapped port %d to %s.", port, m_upnp_ourip.c_str());
-  return;
-fail:
   WARN_LOG(NETPLAY, "Failed to map port %d to %s.", port, m_upnp_ourip.c_str());
-  return;
 }
 
 // UPnP thread: try to unmap a port