Small improvement to cmpli/cmpi in ARMJit.

dolphin-emu · Feb 27, 2013 · 9ff704f · 9ff704f
1 parent f1d727c
commit 9ff704f
Showing 1 changed file with 21 additions and 7 deletions.
diff --git a/Source/Core/Core/Src/PowerPC/JitArm32/JitArm_Integer.cpp b/Source/Core/Core/Src/PowerPC/JitArm32/JitArm_Integer.cpp
@@ -193,11 +193,18 @@ void JitArm::cmpi(UGeckoInstruction inst)
 	JITDISABLE(Integer)
 
 	ARMReg RA = gpr.R(inst.RA);
-	ARMReg rA = gpr.GetReg();
 	int crf = inst.CRFD;
-	MOVI2R(rA, inst.SIMM_16);
-	CMP(RA, rA);
-	gpr.Unlock(rA);
+	if (inst.SIMM_16 >= 0 && inst.SIMM_16 < 256)
+	{
+		CMP(RA, inst.SIMM_16);
+	}
+	else
+	{
+		ARMReg rA = gpr.GetReg();
+		MOVI2R(rA, inst.SIMM_16);
+		CMP(RA, rA);
+		gpr.Unlock(rA);
+	}
 	ComputeRC(crf);
 }
 void JitArm::cmpli(UGeckoInstruction inst)
@@ -208,9 +215,16 @@ void JitArm::cmpli(UGeckoInstruction inst)
 	ARMReg RA = gpr.R(inst.RA);
 	ARMReg rA = gpr.GetReg();
 	int crf = inst.CRFD;
-	MOVI2R(rA, (u32)inst.UIMM);
-	CMP(RA, rA);
-
+	u32 uimm = (u32)inst.UIMM;
+	if (uimm < 256)
+	{
+		CMP(RA, uimm);
+	}
+	else
+	{
+		MOVI2R(rA, (u32)inst.UIMM);
+		CMP(RA, rA);
+	}
 	// Unsigned GenerateRC()
 
 	MOV(rA, 0x2); // Result == 0