Merge pull request #11803 from LillyJadeKatrin/retroachievements-bugfix

Added Invalid Request Drop to AchievementManager Request
dolphin-emu · Apr 29, 2023 · aaf11e6 · aaf11e6
2 parents 28f1a4c + 9778640
commit aaf11e6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp
@@ -384,6 +384,8 @@ AchievementManager::ResponseType AchievementManager::Request(
   rc_api_request_t api_request;
   Common::HttpRequest http_request;
   init_request(&api_request, &rc_request);
+  if (!api_request.post_data)
+    return ResponseType::INVALID_REQUEST;
   auto http_response = http_request.Post(api_request.url, api_request.post_data);
   rc_api_destroy_request(&api_request);
   if (http_response.has_value() && http_response->size() > 0)

diff --git a/Source/Core/Core/AchievementManager.h b/Source/Core/Core/AchievementManager.h
@@ -26,6 +26,7 @@ class AchievementManager
   {
     SUCCESS,
     MANAGER_NOT_INITIALIZED,
+    INVALID_REQUEST,
     INVALID_CREDENTIALS,
     CONNECTION_FAILED,
     UNKNOWN_FAILURE