Merge pull request #10309 from aldelaro5/gdb-stub-fix-watchpoints

Gdb stub: fix watchpoints
dolphin-emu · Jan 3, 2022 · cbd1c49 · cbd1c49
2 parents 27a2df4 + 9c784ca
commit cbd1c49
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Source/Core/Core/PowerPC/GDBStub.cpp b/Source/Core/Core/PowerPC/GDBStub.cpp
@@ -53,11 +53,13 @@ enum class BreakpointType
 {
   ExecuteSoft = 0,
   ExecuteHard,
-  Read,
   Write,
+  Read,
   Access,
 };
 
+constexpr u32 NUM_BREAKPOINT_TYPES = 4;
+
 const s64 GDB_UPDATE_CYCLES = 100000;
 
 static bool s_has_control = false;
@@ -858,7 +860,7 @@ static void HandleAddBreakpoint()
   u32 i, addr = 0, len = 0;
 
   type = Hex2char(s_cmd_bfr[1]);
-  if (type > 4)
+  if (type > NUM_BREAKPOINT_TYPES)
     return SendReply("E01");
 
   i = 3;
@@ -879,7 +881,7 @@ static void HandleRemoveBreakpoint()
   u32 type, addr, len, i;
 
   type = Hex2char(s_cmd_bfr[1]);
-  if (type >= 4)
+  if (type > NUM_BREAKPOINT_TYPES)
     return SendReply("E01");
 
   addr = 0;