Skip to content
Permalink
Browse files

VolumeVerifier: Allocate QProgressDialog on stack

No reason to have it on the heap.

This also lets us skip calling reset, since the dialog closes
when the QProgressDialog object goes out of scope.
  • Loading branch information...
JosJuice committed Aug 9, 2019
1 parent e87a3f9 commit cd02ca17ce2927a9b004d418353073c50ca1ba77
Showing with 9 additions and 9 deletions.
  1. +9 −9 Source/Core/DolphinQt/Config/VerifyWidget.cpp
@@ -98,26 +98,26 @@ void VerifyWidget::Verify()
// We have to divide the number of processed bytes with something so it won't make ints overflow
constexpr int DIVISOR = 0x100;

QProgressDialog* progress = new QProgressDialog(tr("Verifying"), tr("Cancel"), 0,
verifier.GetTotalBytes() / DIVISOR, this);
progress->setWindowTitle(tr("Verifying"));
progress->setWindowFlags(progress->windowFlags() & ~Qt::WindowContextHelpButtonHint);
progress->setMinimumDuration(500);
progress->setWindowModality(Qt::WindowModal);
QProgressDialog progress(tr("Verifying"), tr("Cancel"), 0, verifier.GetTotalBytes() / DIVISOR,
this);
progress.setWindowTitle(tr("Verifying"));
progress.setWindowFlags(progress.windowFlags() & ~Qt::WindowContextHelpButtonHint);
progress.setMinimumDuration(500);
progress.setWindowModality(Qt::WindowModal);

verifier.Start();
while (verifier.GetBytesProcessed() != verifier.GetTotalBytes())
{
progress->setValue(verifier.GetBytesProcessed() / DIVISOR);
if (progress->wasCanceled())
progress.setValue(verifier.GetBytesProcessed() / DIVISOR);
if (progress.wasCanceled())
return;

verifier.Process();
}
verifier.Finish();

DiscIO::VolumeVerifier::Result result = verifier.GetResult();
progress->reset();
progress.setValue(verifier.GetBytesProcessed() / DIVISOR);

m_summary_text->setText(QString::fromStdString(result.summary_text));

0 comments on commit cd02ca1

Please sign in to comment.
You can’t perform that action at this time.