diff --git a/Source/Core/VideoBackends/Software/EfbInterface.cpp b/Source/Core/VideoBackends/Software/EfbInterface.cpp index 8eebb375d3e1..9548dece5ae8 100644 --- a/Source/Core/VideoBackends/Software/EfbInterface.cpp +++ b/Source/Core/VideoBackends/Software/EfbInterface.cpp @@ -588,8 +588,9 @@ void EncodeXFB(u8* xfb_in_ram, u32 memory_stride, const MathUtil::Rectangle // // In our implementation, the garbage just so happens to be the top or bottom row. // Statistically, that could happen. - u16 y_prev = static_cast(std::max(clamp_top ? source_rect.top : 0, y - 1)); - u16 y_next = static_cast(std::min(clamp_bottom ? source_rect.bottom : EFB_HEIGHT, y + 1)); + const u16 y_prev = static_cast(std::max(clamp_top ? source_rect.top : 0, y - 1)); + const u16 y_next = + static_cast(std::min(clamp_bottom ? source_rect.bottom : EFB_HEIGHT, y + 1)); // Get a scanline of YUV pixels in 4:4:4 format for (int i = 1, x = left; x < right; i++, x++) diff --git a/Source/Core/VideoCommon/VideoCommon.h b/Source/Core/VideoCommon/VideoCommon.h index e727edd0b0a7..21aa5236a9ea 100644 --- a/Source/Core/VideoCommon/VideoCommon.h +++ b/Source/Core/VideoCommon/VideoCommon.h @@ -10,21 +10,18 @@ extern bool g_bRecordFifoData; // These are accurate (disregarding AA modes). -enum -{ - EFB_WIDTH = 640, - EFB_HEIGHT = 528, -}; +constexpr u32 EFB_WIDTH = 640; +constexpr u32 EFB_HEIGHT = 528; // Max XFB width is 720. You can only copy out 640 wide areas of efb to XFB // so you need multiple copies to do the full width. // The VI can do horizontal scaling (TODO: emulate). -const u32 MAX_XFB_WIDTH = 720; +constexpr u32 MAX_XFB_WIDTH = 720; // Although EFB height is 528, 576-line XFB's can be created either with // vertical scaling by the EFB copy operation or copying to multiple XFB's // that are next to each other in memory (TODO: handle that situation). -const u32 MAX_XFB_HEIGHT = 576; +constexpr u32 MAX_XFB_HEIGHT = 576; #ifdef _WIN32 #define PRIM_LOG(...) DEBUG_LOG(VIDEO, __VA_ARGS__)