Merge pull request #5956 from Armada651/fix-remove-clr-usage

RenderState: Fix incorrect blending factors when removing the color usage.
dolphin-emu · Aug 21, 2017 · d0fc223 · d0fc223
2 parents 8280d15 + 390f3f1
commit d0fc223
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Source/Core/VideoCommon/RenderState.cpp b/Source/Core/VideoCommon/RenderState.cpp
@@ -94,9 +94,10 @@ void BlendingState::Generate(const BPMemory& bp)
       srcfactor = RemoveDstAlphaUsage(srcfactor);
       dstfactor = RemoveDstAlphaUsage(dstfactor);
     }
-    // replaces SRCCLR with SRCALPHA
-    srcfactoralpha = RemoveSrcColorUsage(srcfactor);
-    dstfactoralpha = RemoveDstColorUsage(dstfactor);
+    // replaces SRCCLR with SRCALPHA and DSTCLR with DSTALPHA, it is important to
+    // use the dst function for the src factor and vice versa
+    srcfactoralpha = RemoveDstColorUsage(srcfactor);
+    dstfactoralpha = RemoveSrcColorUsage(dstfactor);
 
     if (dstalpha)
     {