Please sign in to comment.
CodeViewWidget: Get rid of magic values in OnInsertBLR() and OnInsert…
…NOP() A call like ReplaceAddress(address, 0) is pretty ambiguous; so is ReplaceAddress(address, false), so use an enum class that tells people straight-up what the replacer is. This also gets rid of the really weird naming, where if 'blr' is true, we'd be replacing the address with a NOP, rather than an actual BLR instruction, so we invert that so it actually makes sense. There's no actual bug fixed here though, considering the OnInsert functions specified the correct values; it's literally just weird naming.
- Loading branch information...
Showing with 12 additions and 6 deletions.