Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #8743 from Techjar/apple-pls-support-standard-api
VideoBackends: Disable GPU Texture Decoding under MoltenVK
  • Loading branch information
JMC47 committed Sep 10, 2020
2 parents 7cab8b7 + 69358b2 commit dcbe9da
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
4 changes: 4 additions & 0 deletions Source/Core/VideoBackends/Vulkan/VulkanContext.cpp
Expand Up @@ -346,6 +346,10 @@ void VulkanContext::PopulateBackendInfoFeatures(VideoConfig* config, VkPhysicalD
// with depth clamping. Fall back to inverted depth range for these.
if (DriverDetails::HasBug(DriverDetails::BUG_BROKEN_REVERSED_DEPTH_RANGE))
config->backend_info.bSupportsReversedDepthRange = false;

// GPU Texture Decoding is broken under MoltenVK.
if (DriverDetails::HasBug(DriverDetails::BUG_BROKEN_GPU_TEXTURE_DECODING))
config->backend_info.bSupportsGPUTextureDecoding = false;
}

void VulkanContext::PopulateBackendInfoMultisampleModes(
Expand Down
5 changes: 4 additions & 1 deletion Source/Core/VideoCommon/DriverDetails.cpp
Expand Up @@ -117,7 +117,10 @@ constexpr BugInfo m_known_bugs[] = {
{API_VULKAN, OS_ALL, VENDOR_ARM, DRIVER_ARM, Family::UNKNOWN, BUG_SLOW_CACHED_READBACK_MEMORY,
-1.0, -1.0, true},
{API_VULKAN, OS_ALL, VENDOR_QUALCOMM, DRIVER_QUALCOMM, Family::UNKNOWN,
BUG_SLOW_CACHED_READBACK_MEMORY, -1.0, -1.0, true}};
BUG_SLOW_CACHED_READBACK_MEMORY, -1.0, -1.0, true},
{API_VULKAN, OS_OSX, VENDOR_ALL, DRIVER_PORTABILITY, Family::UNKNOWN,
BUG_BROKEN_GPU_TEXTURE_DECODING, -1.0, -1.0, true},
};

static std::map<Bug, BugInfo> m_bugs;

Expand Down
4 changes: 4 additions & 0 deletions Source/Core/VideoCommon/DriverDetails.h
Expand Up @@ -286,6 +286,10 @@ enum Bug
// Mali Vulkan driver, causing high CPU usage in the __pi___inval_cache_range kernel
// function. This flag causes readback buffers to select the coherent type.
BUG_SLOW_CACHED_READBACK_MEMORY,

// BUG: GPU Texture Decoding produces a spectacular mess or just outright crashes when using
// Vulkan on macOS through MoltenVK.
BUG_BROKEN_GPU_TEXTURE_DECODING,
};

// Initializes our internal vendor, device family, and driver version
Expand Down

0 comments on commit dcbe9da

Please sign in to comment.