Merge pull request #10871 from shuffle2/logging

logging improvements
dolphin-emu · Jul 18, 2022 · dd67d5f · dd67d5f
2 parents f43fa8a + 2882843
commit dd67d5f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/Source/Core/AudioCommon/CubebUtils.cpp b/Source/Core/AudioCommon/CubebUtils.cpp
@@ -22,6 +22,10 @@ static void LogCallback(const char* format, ...)
   if (instance == nullptr)
     return;
 
+  constexpr auto log_type = Common::Log::LogType::AUDIO;
+  if (!instance->IsEnabled(log_type))
+    return;
+
   va_list args;
   va_start(args, format);
   const char* filename = va_arg(args, const char*) + s_path_cutoff_point;
@@ -30,8 +34,8 @@ static void LogCallback(const char* format, ...)
   const std::string message = StringFromFormatV(adapted_format.c_str(), args);
   va_end(args);
 
-  instance->Log(Common::Log::LogLevel::LNOTICE, Common::Log::LogType::AUDIO, filename, lineno,
-                message.c_str());
+  instance->LogWithFullPath(Common::Log::LogLevel::LNOTICE, log_type, filename, lineno,
+                            message.c_str());
 }
 
 static void DestroyContext(cubeb* ctx)
@@ -54,6 +58,8 @@ std::shared_ptr<cubeb> CubebUtils::GetContext()
 
   const char* filename = __FILE__;
   const char* match_point = strstr(filename, DIR_SEP "Source" DIR_SEP "Core" DIR_SEP);
+  if (!match_point)
+    match_point = strstr(filename, R"(\Source\Core\)");
   if (match_point)
   {
     s_path_cutoff_point = match_point - filename + strlen(DIR_SEP "Externals" DIR_SEP);

diff --git a/Source/Core/Common/Logging/LogManager.h b/Source/Core/Common/Logging/LogManager.h
@@ -39,6 +39,8 @@ class LogManager
   static void Shutdown();
 
   void Log(LogLevel level, LogType type, const char* file, int line, const char* message);
+  void LogWithFullPath(LogLevel level, LogType type, const char* file, int line,
+                       const char* message);
 
   LogLevel GetLogLevel() const;
   void SetLogLevel(LogLevel level);
@@ -73,9 +75,6 @@ class LogManager
   LogManager(LogManager&&) = delete;
   LogManager& operator=(LogManager&&) = delete;
 
-  void LogWithFullPath(LogLevel level, LogType type, const char* file, int line,
-                       const char* message);
-
   LogLevel m_level;
   EnumMap<LogContainer, LogType::WIIMOTE> m_log{};
   std::array<LogListener*, LogListener::NUMBER_OF_LISTENERS> m_listeners{};

diff --git a/Source/Core/DolphinQt/Config/LogWidget.cpp b/Source/Core/DolphinQt/Config/LogWidget.cpp
@@ -102,7 +102,7 @@ void LogWidget::UpdateLog()
     const std::string_view str_view(std::get<std::string>(line));
 
     m_log_text->appendHtml(
-        QStringLiteral("%1 <span style=\"color: %2; white-space: pre\">%3</span>")
+        QStringLiteral("%1<span style=\"color: %2; white-space: pre\">%3</span>")
             .arg(QStringFromStringView(str_view.substr(0, TIMESTAMP_LENGTH)),
                  QString::fromUtf8(color),
                  QStringFromStringView(str_view.substr(TIMESTAMP_LENGTH)).toHtmlEscaped()));