Permalink
Browse files

Android: Get rid of the per-platform styles, as we only using the GC …

…one.

I think the intention might have been to switch styles based on what
platform was selected, but that never happened. Instead, everything just
used the GC styles.

All the platform-specific styles did was add an accent color (which
tints the checkbox and text area elements). This adds a specific color for
that instead of abusing a platform color.

There should be no visual changes for this commit.
  • Loading branch information...
hackbar committed Aug 11, 2018
1 parent 248afb9 commit dd8d7bba9868f92ea5a08c9e857ae05b9ea43652
@@ -31,7 +31,7 @@
<activity
android:name=".ui.main.MainActivity"
android:theme="@style/DolphinGamecube">
android:theme="@style/DolphinBase">
<!-- This intentfilter marks this Activity as the one that gets launched from Home screen. -->
<intent-filter>
@@ -43,7 +43,7 @@
<activity
android:name=".ui.main.TvMainActivity"
android:theme="@style/DolphinTvGamecube">
android:theme="@style/DolphinTvBase">
<!-- This intentfilter marks this Activity as the one that gets launched from Home screen. -->
<intent-filter>
@@ -55,12 +55,12 @@
<activity
android:name=".features.settings.ui.SettingsActivity"
android:theme="@style/DolphinSettingsGamecube"
android:theme="@style/DolphinSettingsBase"
android:label="@string/preferences_settings"/>
<activity
android:name=".activities.EmulationActivity"
android:theme="@style/DolphinEmulationGamecube"/>
android:theme="@style/DolphinEmulationBase"/>
<activity
android:name=".activities.CustomFilePickerActivity"
@@ -81,7 +81,6 @@
</intent-filter>
</activity>
<service android:name=".services.DirectoryInitializationService"/>
<service android:name=".services.GameFileCacheService"/>
<service
@@ -210,7 +210,7 @@ protected void onCreate(Bundle savedInstanceState)
int themeId;
if (mDeviceHasTouchScreen)
{
themeId = R.style.DolphinEmulationGamecube;
themeId = R.style.DolphinEmulationBase;
// Get a handle to the Window containing the UI.
mDecorView = getWindow().getDecorView();
@@ -229,7 +229,7 @@ protected void onCreate(Bundle savedInstanceState)
}
else
{
themeId = R.style.DolphinEmulationTvGamecube;
themeId = R.style.DolphinEmulationTvBase;
}
setTheme(themeId);
@@ -3,6 +3,7 @@
<color name="dolphin_blue">#2196f3</color>
<color name="dolphin_blue_dark">#1976d2</color>
<color name="dolphin_purple">#651fff</color>
<color name="dolphin_accent_wii">#9e9e9e</color>
<color name="dolphin_accent_wiiware">#2979ff</color>
@@ -8,6 +8,7 @@
<item name="colorPrimary">@color/dolphin_blue</item>
<!-- Darker variant for the status bar and contextual app bars -->
<item name="colorPrimaryDark">@color/dolphin_blue_dark</item>
<item name="colorAccent">@color/dolphin_purple</item>
<!-- Enable window content transitions -->
<item name="android:windowContentTransitions">true</item>
@@ -21,34 +22,7 @@
<style name="DolphinSettingsBase" parent="Theme.AppCompat.Light.DarkActionBar">
<item name="colorPrimary">@color/dolphin_blue</item>
<item name="colorPrimaryDark">@color/dolphin_blue_dark</item>
</style>
<!-- Inherit from the Base Dolphin Theme -->
<style name="DolphinWii" parent="DolphinBase">
<!-- Theme UI controls like checkboxes and text fields -->
<item name="colorAccent">@color/dolphin_accent_wii</item>
</style>
<style name="DolphinGamecube" parent="DolphinBase">
<item name="colorAccent">@color/dolphin_accent_gamecube</item>
</style>
<style name="DolphinWiiware" parent="DolphinBase">
<item name="colorAccent">@color/dolphin_accent_wiiware</item>
</style>
<!-- Inherit from the Base Dolphin Settings Theme -->
<style name="DolphinSettingsWii" parent="DolphinSettingsBase">
<item name="colorAccent">@color/dolphin_accent_wii</item>
</style>
<style name="DolphinSettingsGamecube" parent="DolphinSettingsBase">
<item name="colorAccent">@color/dolphin_accent_gamecube</item>
</style>
<style name="DolphinSettingsWiiware" parent="DolphinSettingsBase">
<!-- Theme UI controls like checkboxes and text fields -->
<item name="colorAccent">@color/dolphin_accent_wiiware</item>
<item name="colorAccent">@color/dolphin_purple</item>
</style>
<!-- Themes for Dialogs -->
@@ -58,6 +32,7 @@
<style name="DolphinEmulationBase" parent="Theme.AppCompat.Light.DarkActionBar">
<item name="colorPrimary">@color/dolphin_blue</item>
<item name="colorPrimaryDark">@color/dolphin_blue_dark</item>
<item name="colorAccent">@color/dolphin_purple</item>
<item name="android:windowTranslucentNavigation">true</item>
<item name="android:windowBackground">@android:color/black</item>
@@ -68,22 +43,10 @@
<item name="android:windowAllowReturnTransitionOverlap">true</item>
</style>
<!-- Inherit from the Base Dolphin Emulation Theme -->
<style name="DolphinEmulationWii" parent="DolphinEmulationBase">
<item name="colorAccent">@color/dolphin_accent_wii</item>
</style>
<style name="DolphinEmulationGamecube" parent="DolphinEmulationBase">
<item name="colorAccent">@color/dolphin_accent_gamecube</item>
</style>
<style name="DolphinEmulationWiiware" parent="DolphinEmulationBase">
<item name="colorAccent">@color/dolphin_accent_wiiware</item>
</style>
<style name="DolphinEmulationTvBase" parent="Theme.AppCompat.Light.NoActionBar">
<item name="colorPrimary">@color/dolphin_blue</item>
<item name="colorPrimaryDark">@color/dolphin_blue_dark</item>
<item name="colorAccent">@color/dolphin_purple</item>
<item name="android:windowTranslucentNavigation">true</item>
<item name="android:windowBackground">@android:color/black</item>
@@ -94,19 +57,6 @@
<item name="android:windowAllowReturnTransitionOverlap">true</item>
</style>
<!-- Inherit from the Base Dolphin Emulation Theme -->
<style name="DolphinEmulationTvWii" parent="DolphinEmulationTvBase">
<item name="colorAccent">@color/dolphin_accent_wii</item>
</style>
<style name="DolphinEmulationTvGamecube" parent="DolphinEmulationTvBase">
<item name="colorAccent">@color/dolphin_accent_gamecube</item>
</style>
<style name="DolphinEmulationTvWiiware" parent="DolphinEmulationTvBase">
<item name="colorAccent">@color/dolphin_accent_wiiware</item>
</style>
<!-- Hax to make Tablayout render icons -->
<style name="MyCustomTextAppearance" parent="TextAppearance.Design.Tab">
<item name="textAllCaps">false</item>
@@ -116,15 +66,14 @@
<style name="DolphinTvBase" parent="Theme.Leanback.Browse">
<item name="colorPrimary">@color/dolphin_blue</item>
<item name="colorPrimaryDark">@color/dolphin_blue_dark</item>
<item name="colorAccent">@color/dolphin_purple</item>
<!-- Enable window content transitions -->
<item name="android:windowContentTransitions">true</item>
<item name="android:windowAllowEnterTransitionOverlap">true</item>
<item name="android:windowAllowReturnTransitionOverlap">true</item>
</style>
<style name="DolphinTvGamecube" parent="DolphinTvBase">
<item name="colorAccent">@color/dolphin_accent_gamecube</item>
<!-- Use CustomTitleView as the leanback title view. -->
<item name="browseTitleViewLayout">@layout/titleview</item>
</style>

0 comments on commit dd8d7bb

Please sign in to comment.