Permalink
Browse files

Common/DebugInterface: Namespace code under the Common namespace

Gets more identifiers out of the global namespace and makes it more in
line with the rest of the (mostly) namespaced Common code.
  • Loading branch information...
lioncash committed Jul 10, 2018
1 parent 9487892 commit dfdfe6c972f91334ca4b9b25ee2d03ab954ea547
@@ -13,6 +13,8 @@
#include "Common/Debug/MemoryPatches.h"
#include "Common/Debug/Watches.h"
namespace Common
{
class DebugInterface
{
protected:
@@ -75,3 +77,4 @@ class DebugInterface
virtual std::string GetDescription(unsigned int /*address*/) = 0;
virtual void Clear() = 0;
};
} // namespace Common
@@ -17,7 +17,7 @@ class PPCPatches : public Common::Debug::MemoryPatches
// wrapper between disasm control and Dolphin debugger
class PPCDebugInterface final : public DebugInterface
class PPCDebugInterface final : public Common::DebugInterface
{
public:
PPCDebugInterface() {}
@@ -20,7 +20,7 @@ class DSPPatches : public Common::Debug::MemoryPatches
void Patch(std::size_t index) override;
};
class DSPDebugInterface final : public DebugInterface
class DSPDebugInterface final : public Common::DebugInterface
{
public:
DSPDebugInterface() {}
@@ -226,7 +226,7 @@ bool MemChecks::OverlapsMemcheck(u32 address, u32 length) const
});
}
bool TMemCheck::Action(DebugInterface* debug_interface, u32 value, u32 addr, bool write,
bool TMemCheck::Action(Common::DebugInterface* debug_interface, u32 value, u32 addr, bool write,
size_t size, u32 pc)
{
if ((write && is_break_on_write) || (!write && is_break_on_read))
@@ -10,7 +10,10 @@
#include "Common/CommonTypes.h"
namespace Common
{
class DebugInterface;
}
struct TBreakPoint
{
@@ -35,7 +38,8 @@ struct TMemCheck
u32 num_hits = 0;
// returns whether to break
bool Action(DebugInterface* dbg_interface, u32 value, u32 addr, bool write, size_t size, u32 pc);
bool Action(Common::DebugInterface* dbg_interface, u32 value, u32 addr, bool write, size_t size,
u32 pc);
};
// Code breakpoints.
@@ -39,7 +39,7 @@ class PPCSymbolDB : public Common::SymbolDB
void LogFunctionCall(u32 addr);
private:
DebugInterface* debugger;
Common::DebugInterface* debugger;
};
extern PPCSymbolDB g_symbolDB;

0 comments on commit dfdfe6c

Please sign in to comment.