From 38f045cee568e538a399cc8b21aeea6555925cbd Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 23 Mar 2018 07:35:34 -0400 Subject: [PATCH] DolphinQt2/GameCubePane: Correct duplicate condition in LoadSettings() Also turns a std::string const reference into a value instance. While this is well-defined, it does look out of place, given a new string is being created. --- Source/Core/DolphinQt2/Settings/GameCubePane.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/DolphinQt2/Settings/GameCubePane.cpp b/Source/Core/DolphinQt2/Settings/GameCubePane.cpp index 2360a5f19e23..bea623784a01 100644 --- a/Source/Core/DolphinQt2/Settings/GameCubePane.cpp +++ b/Source/Core/DolphinQt2/Settings/GameCubePane.cpp @@ -240,9 +240,9 @@ void GameCubePane::LoadSettings() for (const std::string& dir : {USA_DIR, JAP_DIR, EUR_DIR}) { - const auto& path = DIR_SEP + dir + DIR_SEP GC_IPL; + const auto path = DIR_SEP + dir + DIR_SEP GC_IPL; if (File::Exists(File::GetUserPath(D_GCUSER_IDX) + path) || - File::Exists(File::GetUserPath(D_GCUSER_IDX) + path)) + File::Exists(File::GetSysDirectory() + GC_SYS_DIR + path)) { have_menu = true; break;