Skip to content
Permalink
Browse files

DolphinQt/CMakeLists: Collapse name setting code for Windows

Its sufficient to simply specify a debug postfix instead of using an
separate variable. What's nice about this approach is that it will
actually work :p

Previously the code wouldn't work for multi-configuration generators
like Visual Studio.
  • Loading branch information...
lioncash committed Jun 18, 2019
1 parent b3525ad commit e8fd834d8f320296f68c273a06e0ca52bce4ac40
Showing with 2 additions and 7 deletions.
  1. +2 −7 Source/Core/DolphinQt/CMakeLists.txt
@@ -281,15 +281,10 @@ PRIVATE
if(WIN32)
target_sources(dolphin-emu PRIVATE DolphinQt.manifest DolphinQt.rc)

if (CMAKE_BUILD_TYPE STREQUAL "Debug")
set(Dolphin_NAME "DolphinD")
else()
set(Dolphin_NAME "Dolphin")
endif()

set_target_properties(dolphin-emu PROPERTIES
DEBUG_POSTFIX D
OUTPUT_NAME Dolphin
WIN32_EXECUTABLE TRUE
OUTPUT_NAME ${Dolphin_NAME}
)

target_compile_options(dolphin-emu PRIVATE "-D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING")

0 comments on commit e8fd834

Please sign in to comment.
You can’t perform that action at this time.