Merge pull request #663 from moshekaplan/patch-1

Prevent potential buffer overflow in sscanf
dolphin-emu · Jul 23, 2014 · e91db62 · e91db62
2 parents 008b907 + cd8b65b
commit e91db62
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Source/Core/DolphinWX/Android/ButtonManager.cpp b/Source/Core/DolphinWX/Android/ButtonManager.cpp
@@ -117,13 +117,13 @@ namespace ButtonManager
 				{
 					hasbind = true;
 					type = BIND_AXIS;
-					sscanf(value.c_str(), "Device '%[^\']'-Axis %d%c", dev, &bindnum, &modifier);
+					sscanf(value.c_str(), "Device '%127[^\']'-Axis %d%c", dev, &bindnum, &modifier);
 				}
 				else if (std::string::npos != value.find("Button"))
 				{
 					hasbind = true;
 					type = BIND_BUTTON;
-					sscanf(value.c_str(), "Device '%[^\']'-Button %d", dev, &bindnum);
+					sscanf(value.c_str(), "Device '%127[^\']'-Button %d", dev, &bindnum);
 				}
 				if (hasbind)
 					AddBind(std::string(dev), new sBind(padID, configTypes[a], type, bindnum, modifier == '-' ? -1.0f : 1.0f));