Merge pull request #12147 from Dentomologist/pagefaulttest_use_gtest_…

…skip PageFaultTest: Use GTEST_SKIP instead of early return
dolphin-emu · Aug 29, 2023 · efa8207 · efa8207
2 parents 1b2d0c0 + 75a62e1
commit efa8207
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/Source/UnitTests/Core/PageFaultTest.cpp b/Source/UnitTests/Core/PageFaultTest.cpp
@@ -68,10 +68,8 @@ static void ASAN_DISABLE perform_invalid_access(void* data)
 TEST(PageFault, PageFault)
 {
   if (!EMM::IsExceptionHandlerSupported())
-  {
-    // TODO: Use GTEST_SKIP() instead when GTest is updated to 1.10+
-    return;
-  }
+    GTEST_SKIP() << "Skipping PageFault test because exception handler is unsupported.";
+
   EMM::InstallExceptionHandler();
   void* data = Common::AllocateMemoryPages(PAGE_GRAN);
   EXPECT_NE(data, nullptr);