Skip to content
Permalink
Browse files

Merge pull request #8410 from spycrab/cmake_win_warnings

CMake/Windows: Fix warnings about flags being overridden
  • Loading branch information...
spycrab committed Oct 25, 2019
2 parents c6da1f0 + 1aeb490 commit f54faedd7624d156f1b05e620ecf5aae9acbb8d5
Showing with 8 additions and 2 deletions.
  1. +8 −2 Source/CMakeLists.txt
@@ -15,8 +15,14 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

if (MSVC)
# Set warning level to 4
add_compile_options(/W4)
# TODO: Use https://cmake.org/cmake/help/latest/policy/CMP0092.html instead (once we can require CMake >= 3.15)
# Taken from http://www.cmake.org/Wiki/CMake_FAQ#Dynamic_Replace.
foreach(flag_var
CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
MAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
# Replaces /W3 with /W4 in defaults (add_compile_options would cause very annoying warnings here)
string(REPLACE "/W3" "/W4" ${flag_var} "${${flag_var}}")
endforeach()

# Disable some warnings
add_compile_options(

0 comments on commit f54faed

Please sign in to comment.
You can’t perform that action at this time.