Permalink
Commits on Aug 15, 2018
  1. Arm64Emitter: Get rid of a pointer cast within SetJumpTarget()

    lioncash committed Aug 15, 2018
    Type punning like this is undefined behavior. Instead, we use std::memcpy to
    copy the necessary data over, which is well defined (as it treats both
    the source and destination as unsigned char).
Commits on Aug 12, 2018
  1. PowerPC: Deduplicate Helper_Mask() code

    lioncash committed Aug 12, 2018
    We can share this across all implementations instead of duplicating it
    in different ways.
  2. Merge pull request #7321 from VPeruS/fix-assignment

    lioncash committed Aug 12, 2018
    Core/UICommon: Fix assignment to pointer
Commits on Aug 11, 2018
  1. Merge pull request #7316 from JMC47/removelswxpanic

    lioncash committed Aug 11, 2018
    Disable a panic alert in lswx that makes using not64 impossible
Commits on Aug 9, 2018
  1. Merge pull request #7309 from JosJuice/remove-frameskip-even-more

    lioncash committed Aug 9, 2018
    ConfigManager: Remove m_FrameSkip
Commits on Aug 8, 2018
  1. Merge pull request #7286 from orbea/cubeb

    lioncash committed Aug 8, 2018
    cmake: Support shared cubeb builds.
Commits on Aug 4, 2018
  1. NetPlayServer: Make g_initial_netplay_rtc a member variable of NetPla…

    lioncash committed Jul 14, 2018
    …yClient
    
    Behaviorally, this belongs within the netplay client. The server will
    always transmit a known RTC value, so it doesn't even need a global for
    this. Given the client receives the packet containing said RTC value, we can
    store it as a member variable and provide an accessor for reading that
    value.
    
    This removes another global variable within the netplay code.
Commits on Jul 21, 2018
  1. Merge pull request #7282 from booto/no-more-global-dcbz-disable

    lioncash committed Jul 21, 2018
    Config: Remove Core::DCBZ [bDCBZOFF] - obsolete
Commits on Jul 20, 2018
  1. Merge pull request #7281 from JMC47/rubiks

    lioncash committed Jul 20, 2018
    Update INI for Rubik's Rush
Commits on Jul 18, 2018
  1. Merge pull request #7280 from Techjar/qt-cheats-manager-crash

    lioncash committed Jul 18, 2018
    Qt/CheatsManager: Fix segfault in GenerateARCode
Commits on Jul 17, 2018
  1. Merge pull request #7270 from JMC47/NeedForSpeedMWFollowBranch

    lioncash committed Jul 17, 2018
    Disable JITFollowBranch for Need For Speed:MW
  2. Merge pull request #7264 from ligfx/ffmpeg_deprecations

    lioncash committed Jul 17, 2018
    Fix deprecation warnings with recent FFmpeg versions
Commits on Jul 16, 2018
  1. Merge pull request #7271 from JosJuice/remove-wx-settings

    lioncash committed Jul 16, 2018
    Remove settings that only were used by DolphinWX
Commits on Jul 15, 2018
  1. DolphinQt/MainWindow: Replace includes with forward declarations

    lioncash committed Jul 15, 2018
    Reduces the amount of dependencies dragged in by the main window's
    header. This also removes MainWindow.h includes elsewhere where they
    aren't necessary, reducing the amount of UI files that need to be
    recompiled if the main window's header changes.
  2. Core/BootManager: Remove unnecessary includes

    lioncash committed Jul 15, 2018
    Lessens the amount of files that have to be recompiled if
    ConfigManager.h is modified. This also removes an indirect inclusion
    within DolphinQt/Main.cpp.
Commits on Jul 13, 2018
  1. Merge pull request #6641 from BhaaLseN/dsp-update

    lioncash committed Jul 13, 2018
    docs: Update the GameCube DSP User's Manual
Commits on Jul 12, 2018
  1. WiimoteEmu: Make constructor of Wiimote explicit

    lioncash committed Jul 12, 2018
    Prevents implicit conversions
  2. WiimoteEmu: Amend parameter names for EmulateShake() and EmulateSwing()

    lioncash committed Jul 12, 2018
    Ensures they match their naming within the definition of the function.
    
    In EmulateSwing's case, one parameter was erroneously named tilt_group,
    when it's actually supposed to be swing_group.
  3. WiimoteEmu: Remove unnecessary value-wise const from function prototypes

    lioncash committed Jul 12, 2018
    These aren't necessary in the prototype, however they do apply in the
    definition of the function. This just cuts down on line noise within the
    prototypes.
  4. NetPlayClient: Make the NetSettings instance part of the NetPlayClien…

    lioncash committed Jul 9, 2018
    …t class
    
    This is only ever read from externally, so we can expose a getter that ensures that
    immutability, while making the actual instance internal. Given the
    filling out of these settings depends on packets received by the client
    instance, it makes more sense to make it a part of the client itself.
    
    This trims off one lingering global.
Commits on Jul 10, 2018
  1. Qt/GameList: Replace includes with forward declarations where applicable

    lioncash committed Jul 10, 2018
    Avoids dragging in a bunch of includes from the header files, and also
    reduces the amount of files that need to be recompiled if one of those
    included headers' source content is ever changed.
  2. Qt/Resources: Convert int parameters of GetCountry(), GetPlatform() a…

    lioncash committed Jul 10, 2018
    …nd GetMisc() to enum classes
    
    Makes the parameter strongly-typed and doesn't accept arbitrary int
    values.
  3. Qt/CheatsManager: Move concealable types into the cpp file

    lioncash committed Jul 10, 2018
    CompareType, DataType, and Result aren't directly used externally, so
    these can have their definitions moved into the cpp file.
  4. Qt/MenuBar: Make failures to load map and signature files more obvious

    lioncash committed Jul 10, 2018
    Previously we wouldn't indicate if saving or loading these files
    happened to fail. In some cases we'd only print out to the logger, but
    this is a pretty poor way to tell a user of the interface that something
    went wrong in a direct way (the logging messages aren't able to be localized
    either).
Commits on Jul 9, 2018
  1. DolphinQt/Settings: Replace includes with forward declarations

    lioncash committed Jul 9, 2018
    Avoids dragging in netplay-related headers where they aren't explicitly
    necessary.
  2. Merge pull request #7226 from lioncash/netplay

    lioncash committed Jul 9, 2018
    Core: Namespace NetPlay utilities under the NetPlay namespace
Commits on Jul 6, 2018
  1. DolphinQt/PatchesWidget: Remove unused private member variable m_game

    lioncash committed Jul 6, 2018
    This resolves a -Wunused-private-field warning
  2. DolphinQt/GameTracker: Remove unused lambda capture in constructor

    lioncash committed Jul 6, 2018
    This resolves a -Wunused-lambda-capture warning
  3. VideoCommon/TextureCacheBase: Resolve a -Wmissing-braces warning in G…

    lioncash committed Jul 6, 2018
    …etRAMCopyFilterCoefficients()
  4. Core: Namespace NetPlay utilities under the NetPlay namespace

    lioncash committed Jul 6, 2018
    Previously there was only one function under the NetPlay namespace,
    which is kind of silly considering we have all of these other types
    and functions existing outside of the namespace.
    
    This moves the rest of them into the namespace.
    
    This gets some general names, like Player, for example, out of the global namespace.
  5. CMakeLists: Replace tab indentation with spaces

    lioncash committed Jul 6, 2018
    We use spaces everywhere else in the CMake scripts, so this just makes
    indentation consistent.
  6. CMakeLists: Remove trailing space

    lioncash committed Jul 6, 2018
    While we're in the same area, amend the newlining of the if block
  7. CMakeLists: Uppercase "string" in deployment target setting for macOS

    lioncash committed Jul 6, 2018
    The documentation for setting cache entries dicates that the type must
    either be BOOL, FILEPATH, PATH, STRING, or INTERNAL (with those exact
    casings). Also, given we properly case it in other places, this is just
    consistent.
  8. CMakeLists: Use lowercase for commands

    lioncash committed Jul 6, 2018
    The general convention for CMake is to use lowercase for commands, and
    given we also follow that convention through most CMake files, this just
    makes it more consistent.
Commits on Jul 5, 2018
  1. Merge pull request #7141 from lioncash/fp

    lioncash committed Jul 5, 2018
    Interpreter_FPUtils: Handle the FPSCR.ZE and FPSCR.VE flags with arithmetic instructions