31 changes: 17 additions & 14 deletions Source/Core/Core/NetPlayClient.cpp
Expand Up @@ -110,9 +110,9 @@ NetPlayClient::~NetPlayClient()
Disconnect();
}

if (g_MainNetHost.get() == m_client)
if (Common::g_MainNetHost.get() == m_client)
{
g_MainNetHost.release();
Common::g_MainNetHost.release();
}
if (m_client)
{
Expand All @@ -122,7 +122,7 @@ NetPlayClient::~NetPlayClient()

if (m_traversal_client)
{
ReleaseTraversalClient();
Common::ReleaseTraversalClient();
}
}

Expand Down Expand Up @@ -179,18 +179,21 @@ NetPlayClient::NetPlayClient(const std::string& address, const u16 port, NetPlay
}
else
{
if (address.size() > NETPLAY_CODE_SIZE)
if (address.size() > Common::NETPLAY_CODE_SIZE)
{
m_dialog->OnConnectionError(
_trans("The host code is too long.\nPlease recheck that you have the correct code."));
return;
}

if (!EnsureTraversalClient(traversal_config.traversal_host, traversal_config.traversal_port))
if (!Common::EnsureTraversalClient(traversal_config.traversal_host,
traversal_config.traversal_port))
{
return;
m_client = g_MainNetHost.get();
}
m_client = Common::g_MainNetHost.get();

m_traversal_client = g_TraversalClient.get();
m_traversal_client = Common::g_TraversalClient.get();

// If we were disconnected in the background, reconnect.
if (m_traversal_client->HasFailed())
Expand Down Expand Up @@ -1936,16 +1939,16 @@ void NetPlayClient::ClearBuffers()
// called from ---NETPLAY--- thread
void NetPlayClient::OnTraversalStateChanged()
{
const TraversalClient::State state = m_traversal_client->GetState();
const Common::TraversalClient::State state = m_traversal_client->GetState();

if (m_connection_state == ConnectionState::WaitingForTraversalClientConnection &&
state == TraversalClient::State::Connected)
state == Common::TraversalClient::State::Connected)
{
m_connection_state = ConnectionState::WaitingForTraversalClientConnectReady;
m_traversal_client->ConnectToClient(m_host_spec);
}
else if (m_connection_state != ConnectionState::Failure &&
state == TraversalClient::State::Failure)
state == Common::TraversalClient::State::Failure)
{
Disconnect();
m_dialog->OnTraversalError(m_traversal_client->GetFailureReason());
Expand All @@ -1964,19 +1967,19 @@ void NetPlayClient::OnConnectReady(ENetAddress addr)
}

// called from ---NETPLAY--- thread
void NetPlayClient::OnConnectFailed(TraversalConnectFailedReason reason)
void NetPlayClient::OnConnectFailed(Common::TraversalConnectFailedReason reason)
{
m_connecting = false;
m_connection_state = ConnectionState::Failure;
switch (reason)
{
case TraversalConnectFailedReason::ClientDidntRespond:
case Common::TraversalConnectFailedReason::ClientDidntRespond:
PanicAlertFmtT("Traversal server timed out connecting to the host");
break;
case TraversalConnectFailedReason::ClientFailure:
case Common::TraversalConnectFailedReason::ClientFailure:
PanicAlertFmtT("Server rejected traversal attempt");
break;
case TraversalConnectFailedReason::NoSuchClient:
case Common::TraversalConnectFailedReason::NoSuchClient:
PanicAlertFmtT("Invalid host");
break;
default:
Expand Down
10 changes: 5 additions & 5 deletions Source/Core/Core/NetPlayClient.h
Expand Up @@ -68,8 +68,8 @@ class NetPlayUI
virtual void OnDesync(u32 frame, const std::string& player) = 0;
virtual void OnConnectionLost() = 0;
virtual void OnConnectionError(const std::string& message) = 0;
virtual void OnTraversalError(TraversalClient::FailureReason error) = 0;
virtual void OnTraversalStateChanged(TraversalClient::State state) = 0;
virtual void OnTraversalError(Common::TraversalClient::FailureReason error) = 0;
virtual void OnTraversalStateChanged(Common::TraversalClient::State state) = 0;
virtual void OnGameStartAborted() = 0;
virtual void OnGolferChanged(bool is_golfer, const std::string& golfer_name) = 0;

Expand Down Expand Up @@ -107,7 +107,7 @@ class Player
bool IsHost() const { return pid == 1; }
};

class NetPlayClient : public TraversalClientClient
class NetPlayClient : public Common::TraversalClientClient
{
public:
void ThreadFunc();
Expand Down Expand Up @@ -147,7 +147,7 @@ class NetPlayClient : public TraversalClientClient

void OnTraversalStateChanged() override;
void OnConnectReady(ENetAddress addr) override;
void OnConnectFailed(TraversalConnectFailedReason reason) override;
void OnConnectFailed(Common::TraversalConnectFailedReason reason) override;

bool IsFirstInGamePad(int ingame_pad) const;
int NumLocalPads() const;
Expand Down Expand Up @@ -325,7 +325,7 @@ class NetPlayClient : public TraversalClientClient
std::string m_host_spec;
std::string m_player_name;
bool m_connecting = false;
TraversalClient* m_traversal_client = nullptr;
Common::TraversalClient* m_traversal_client = nullptr;
std::thread m_game_digest_thread;
bool m_should_compute_game_digest = false;
Common::Event m_gc_pad_event;
Expand Down
32 changes: 17 additions & 15 deletions Source/Core/Core/NetPlayServer.cpp
Expand Up @@ -98,15 +98,15 @@ NetPlayServer::~NetPlayServer()
m_thread.join();
enet_host_destroy(m_server);

if (g_MainNetHost.get() == m_server)
if (Common::g_MainNetHost.get() == m_server)
{
g_MainNetHost.release();
Common::g_MainNetHost.release();
}

if (m_traversal_client)
{
g_TraversalClient->m_Client = nullptr;
ReleaseTraversalClient();
Common::g_TraversalClient->m_Client = nullptr;
Common::ReleaseTraversalClient();
}
}

Expand All @@ -132,17 +132,19 @@ NetPlayServer::NetPlayServer(const u16 port, const bool forward_port, NetPlayUI*

if (traversal_config.use_traversal)
{
if (!EnsureTraversalClient(traversal_config.traversal_host, traversal_config.traversal_port,
port))
if (!Common::EnsureTraversalClient(traversal_config.traversal_host,
traversal_config.traversal_port, port))
{
return;
}

g_TraversalClient->m_Client = this;
m_traversal_client = g_TraversalClient.get();
Common::g_TraversalClient->m_Client = this;
m_traversal_client = Common::g_TraversalClient.get();

m_server = g_MainNetHost.get();
m_server = Common::g_MainNetHost.get();

if (g_TraversalClient->HasFailed())
g_TraversalClient->ReconnectToServer();
if (Common::g_TraversalClient->HasFailed())
Common::g_TraversalClient->ReconnectToServer();
}
else
{
Expand Down Expand Up @@ -211,7 +213,7 @@ void NetPlayServer::SetupIndex()
if (!m_traversal_client->IsConnected())
return;

session.server_id = std::string(g_TraversalClient->GetHostID().data(), 8);
session.server_id = std::string(Common::g_TraversalClient->GetHostID().data(), 8);
}
else
{
Expand Down Expand Up @@ -1248,15 +1250,15 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)

void NetPlayServer::OnTraversalStateChanged()
{
const TraversalClient::State state = m_traversal_client->GetState();
const Common::TraversalClient::State state = m_traversal_client->GetState();

if (g_TraversalClient->GetHostID()[0] != '\0')
if (Common::g_TraversalClient->GetHostID()[0] != '\0')
SetupIndex();

if (!m_dialog)
return;

if (state == TraversalClient::State::Failure)
if (state == Common::TraversalClient::State::Failure)
m_dialog->OnTraversalError(m_traversal_client->GetFailureReason());

m_dialog->OnTraversalStateChanged(state);
Expand Down
6 changes: 3 additions & 3 deletions Source/Core/Core/NetPlayServer.h
Expand Up @@ -31,7 +31,7 @@ namespace NetPlay
class NetPlayUI;
struct SaveSyncInfo;

class NetPlayServer : public TraversalClientClient
class NetPlayServer : public Common::TraversalClientClient
{
public:
void ThreadFunc();
Expand Down Expand Up @@ -143,7 +143,7 @@ class NetPlayServer : public TraversalClientClient

void OnTraversalStateChanged() override;
void OnConnectReady(ENetAddress) override {}
void OnConnectFailed(TraversalConnectFailedReason) override {}
void OnConnectFailed(Common::TraversalConnectFailedReason) override {}
void UpdatePadMapping();
void UpdateGBAConfig();
void UpdateWiimoteMapping();
Expand Down Expand Up @@ -210,7 +210,7 @@ class NetPlayServer : public TraversalClientClient
bool m_abort_chunked_data = false;

ENetHost* m_server = nullptr;
TraversalClient* m_traversal_client = nullptr;
Common::TraversalClient* m_traversal_client = nullptr;
NetPlayUI* m_dialog = nullptr;
NetPlayIndex m_index;
};
Expand Down
39 changes: 20 additions & 19 deletions Source/Core/DolphinQt/NetPlay/NetPlayDialog.cpp
Expand Up @@ -65,7 +65,7 @@

namespace
{
QString InetAddressToString(const TraversalInetAddress& addr)
QString InetAddressToString(const Common::TraversalInetAddress& addr)
{
QString ip;

Expand Down Expand Up @@ -321,7 +321,7 @@ void NetPlayDialog::ConnectWidgets()
&NetPlayDialog::UpdateGUI);
connect(m_hostcode_action_button, &QPushButton::clicked, [this] {
if (m_is_copy_button_retry)
g_TraversalClient->ReconnectToServer();
Common::g_TraversalClient->ReconnectToServer();
else
QApplication::clipboard()->setText(m_hostcode_label->text());
});
Expand Down Expand Up @@ -581,9 +581,9 @@ void NetPlayDialog::UpdateDiscordPresence()

if (IsHosting())
{
if (g_TraversalClient)
if (Common::g_TraversalClient)
{
const auto host_id = g_TraversalClient->GetHostID();
const auto host_id = Common::g_TraversalClient->GetHostID();
if (host_id[0] == '\0')
return use_default();

Expand Down Expand Up @@ -706,34 +706,35 @@ void NetPlayDialog::UpdateGUI()
}
else if (m_use_traversal)
{
switch (g_TraversalClient->GetState())
switch (Common::g_TraversalClient->GetState())
{
case TraversalClient::State::Connecting:
case Common::TraversalClient::State::Connecting:
m_hostcode_label->setText(tr("Connecting"));
m_hostcode_action_button->setEnabled(false);
m_hostcode_action_button->setText(tr("..."));
break;
case TraversalClient::State::Connected:
case Common::TraversalClient::State::Connected:
{
if (m_room_box->currentIndex() == 0)
{
// Display Room ID.
const auto host_id = g_TraversalClient->GetHostID();
const auto host_id = Common::g_TraversalClient->GetHostID();
m_hostcode_label->setText(
QString::fromStdString(std::string(host_id.begin(), host_id.end())));
}
else
{
// Externally mapped IP and port are known when using the traversal server.
m_hostcode_label->setText(InetAddressToString(g_TraversalClient->GetExternalAddress()));
m_hostcode_label->setText(
InetAddressToString(Common::g_TraversalClient->GetExternalAddress()));
}

m_hostcode_action_button->setEnabled(true);
m_hostcode_action_button->setText(tr("Copy"));
m_is_copy_button_retry = false;
break;
}
case TraversalClient::State::Failure:
case Common::TraversalClient::State::Failure:
m_hostcode_label->setText(tr("Error"));
m_hostcode_action_button->setText(tr("Retry"));
m_hostcode_action_button->setEnabled(true);
Expand Down Expand Up @@ -981,35 +982,35 @@ void NetPlayDialog::OnConnectionError(const std::string& message)
});
}

void NetPlayDialog::OnTraversalError(TraversalClient::FailureReason error)
void NetPlayDialog::OnTraversalError(Common::TraversalClient::FailureReason error)
{
QueueOnObject(this, [this, error] {
switch (error)
{
case TraversalClient::FailureReason::BadHost:
case Common::TraversalClient::FailureReason::BadHost:
ModalMessageBox::critical(this, tr("Traversal Error"), tr("Couldn't look up central server"));
QDialog::reject();
break;
case TraversalClient::FailureReason::VersionTooOld:
case Common::TraversalClient::FailureReason::VersionTooOld:
ModalMessageBox::critical(this, tr("Traversal Error"),
tr("Dolphin is too old for traversal server"));
QDialog::reject();
break;
case TraversalClient::FailureReason::ServerForgotAboutUs:
case TraversalClient::FailureReason::SocketSendError:
case TraversalClient::FailureReason::ResendTimeout:
case Common::TraversalClient::FailureReason::ServerForgotAboutUs:
case Common::TraversalClient::FailureReason::SocketSendError:
case Common::TraversalClient::FailureReason::ResendTimeout:
UpdateGUI();
break;
}
});
}

void NetPlayDialog::OnTraversalStateChanged(TraversalClient::State state)
void NetPlayDialog::OnTraversalStateChanged(Common::TraversalClient::State state)
{
switch (state)
{
case TraversalClient::State::Connected:
case TraversalClient::State::Failure:
case Common::TraversalClient::State::Connected:
case Common::TraversalClient::State::Failure:
UpdateDiscordPresence();
break;
default:
Expand Down
4 changes: 2 additions & 2 deletions Source/Core/DolphinQt/NetPlay/NetPlayDialog.h
Expand Up @@ -67,8 +67,8 @@ class NetPlayDialog : public QDialog, public NetPlay::NetPlayUI
void OnDesync(u32 frame, const std::string& player) override;
void OnConnectionLost() override;
void OnConnectionError(const std::string& message) override;
void OnTraversalError(TraversalClient::FailureReason error) override;
void OnTraversalStateChanged(TraversalClient::State state) override;
void OnTraversalError(Common::TraversalClient::FailureReason error) override;
void OnTraversalStateChanged(Common::TraversalClient::State state) override;
void OnGameStartAborted() override;
void OnGolferChanged(bool is_golfer, const std::string& golfer_name) override;

Expand Down