@@ -192,7 +192,7 @@ void MenuBar::AddFileMenu()
{
QMenu* file_menu = addMenu(tr("&File"));
m_open_action = file_menu->addAction(tr("&Open..."), this, &MenuBar::Open,
QKeySequence(QStringLiteral("Ctrl+O")));
QKeySequence(Qt::CTRL + Qt::Key_O));

file_menu->addSeparator();

@@ -203,8 +203,8 @@ void MenuBar::AddFileMenu()

file_menu->addSeparator();

m_exit_action = file_menu->addAction(tr("E&xit"), this, &MenuBar::Exit,
QKeySequence(QStringLiteral("Alt+F4")));
m_exit_action =
file_menu->addAction(tr("E&xit"), this, &MenuBar::Exit, QKeySequence(Qt::ALT + Qt::Key_F4));
}

void MenuBar::AddToolsMenu()
@@ -244,8 +244,7 @@ void MenuBar::AddToolsMenu()
tools_menu->addSeparator();

// Label will be set by a NANDRefresh later
m_boot_sysmenu =
tools_menu->addAction(QStringLiteral(""), this, [this] { emit BootWiiSystemMenu(); });
m_boot_sysmenu = tools_menu->addAction(QString{}, this, [this] { emit BootWiiSystemMenu(); });
m_wad_install_action = tools_menu->addAction(tr("Install WAD..."), this, &MenuBar::InstallWAD);
m_manage_nand_menu = tools_menu->addMenu(tr("Manage NAND"));
m_import_backup = m_manage_nand_menu->addAction(tr("Import BootMii NAND Backup..."), this,
@@ -328,7 +327,7 @@ void MenuBar::AddStateLoadMenu(QMenu* emu_menu)

for (int i = 1; i <= 10; i++)
{
QAction* action = m_state_load_slots_menu->addAction(QStringLiteral(""));
QAction* action = m_state_load_slots_menu->addAction(QString{});

connect(action, &QAction::triggered, this, [=]() { emit StateLoadSlotAt(i); });
}
@@ -345,7 +344,7 @@ void MenuBar::AddStateSaveMenu(QMenu* emu_menu)

for (int i = 1; i <= 10; i++)
{
QAction* action = m_state_save_slots_menu->addAction(QStringLiteral(""));
QAction* action = m_state_save_slots_menu->addAction(QString{});

connect(action, &QAction::triggered, this, [=]() { emit StateSaveSlotAt(i); });
}
@@ -358,7 +357,7 @@ void MenuBar::AddStateSlotMenu(QMenu* emu_menu)

for (int i = 1; i <= 10; i++)
{
QAction* action = m_state_slot_menu->addAction(QStringLiteral(""));
QAction* action = m_state_slot_menu->addAction(QString{});
action->setCheckable(true);
action->setActionGroup(m_state_slots);
if (Settings::Instance().GetStateSlot() == i)
@@ -482,7 +481,7 @@ void MenuBar::AddViewMenu()
view_menu->addAction(tr("Purge Game List Cache"), this, &MenuBar::PurgeGameListCache);
view_menu->addSeparator();
view_menu->addAction(tr("Search"), this, &MenuBar::ShowSearch,
QKeySequence(QStringLiteral("Ctrl+F")));
QKeySequence(Qt::CTRL + Qt::Key_F));
}

void MenuBar::AddOptionsMenu()
@@ -942,7 +941,7 @@ void MenuBar::UpdateToolsMenu(bool emulation_started)
const QString sysmenu_version =
tmd.IsValid() ?
QString::fromStdString(DiscIO::GetSysMenuVersionString(tmd.GetTitleVersion())) :
QStringLiteral("");
QString{};
m_boot_sysmenu->setText(tr("Load Wii System Menu %1").arg(sysmenu_version));

m_boot_sysmenu->setEnabled(tmd.IsValid());
@@ -1441,8 +1440,8 @@ void MenuBar::LogInstructions()
void MenuBar::SearchInstruction()
{
bool good;
QString op = QInputDialog::getText(this, tr("Search instruction"), tr("Instruction:"),
QLineEdit::Normal, QStringLiteral(""), &good);
const QString op = QInputDialog::getText(this, tr("Search instruction"), tr("Instruction:"),
QLineEdit::Normal, QString{}, &good);

if (!good)
return;
@@ -349,10 +349,9 @@ void NetPlaySetupDialog::PopulateGameList()

m_host_games->sortItems();

QString selected_game = Settings::GetQSettings()
.value(QStringLiteral("netplay/hostgame"), QStringLiteral(""))
.toString();
auto find_list = m_host_games->findItems(selected_game, Qt::MatchFlag::MatchExactly);
const QString selected_game =
Settings::GetQSettings().value(QStringLiteral("netplay/hostgame"), QString{}).toString();
const auto find_list = m_host_games->findItems(selected_game, Qt::MatchFlag::MatchExactly);

if (find_list.count() > 0)
m_host_games->setCurrentItem(find_list[0]);
@@ -10,8 +10,7 @@ class ElidedButton : public QPushButton
{
Q_OBJECT
public:
explicit ElidedButton(const QString& text = QStringLiteral(""),
Qt::TextElideMode elide_mode = Qt::ElideRight);
explicit ElidedButton(const QString& text = {}, Qt::TextElideMode elide_mode = Qt::ElideRight);

Qt::TextElideMode elideMode() const;
void setElideMode(Qt::TextElideMode elide_mode);
@@ -86,8 +86,8 @@ void ResourcePackManager::RepopulateTable()
m_table_widget->clear();
m_table_widget->setColumnCount(6);

m_table_widget->setHorizontalHeaderLabels({QStringLiteral(""), tr("Name"), tr("Version"),
tr("Description"), tr("Author"), tr("Website")});
m_table_widget->setHorizontalHeaderLabels(
{QString{}, tr("Name"), tr("Version"), tr("Description"), tr("Author"), tr("Website")});

auto* header = m_table_widget->horizontalHeader();

@@ -24,7 +24,7 @@ QList<QPixmap> Resources::m_misc;

QIcon Resources::GetIcon(const QString& name, const QString& dir)
{
QString base_path = dir + QStringLiteral("/") + name;
QString base_path = dir + QLatin1Char{'/'} + name;

const auto dpr = QGuiApplication::primaryScreen()->devicePixelRatio();

@@ -317,7 +317,7 @@ void GameCubePane::LoadSettings()
}

m_skip_main_menu->setEnabled(have_menu);
m_skip_main_menu->setToolTip(have_menu ? QStringLiteral("") :
m_skip_main_menu->setToolTip(have_menu ? QString{} :
tr("Put Main Menu roms in User/GC/{region}."));

// Device Settings
@@ -66,7 +66,7 @@ static QComboBox* MakeLanguageComboBox()
};

auto* combobox = new QComboBox();
combobox->addItem(QObject::tr("<System Language>"), QStringLiteral(""));
combobox->addItem(QObject::tr("<System Language>"), QString{});
for (const auto& lang : languages)
combobox->addItem(lang.name, QString::fromLatin1(lang.id));

@@ -135,7 +135,7 @@ void InterfacePane::CreateUI()

auto userstyle_search_results = Common::DoFileSearch({File::GetUserPath(D_STYLES_IDX)});

m_combobox_userstyle->addItem(tr("(None)"), QStringLiteral(""));
m_combobox_userstyle->addItem(tr("(None)"), QString{});

for (const std::string& filename : userstyle_search_results)
{
@@ -79,7 +79,7 @@ void Updater::OnUpdateAvailable(const NewVersionInformation& info)
layout->addWidget(buttons);

connect(never_btn, &QPushButton::clicked, [dialog] {
Settings::Instance().SetAutoUpdateTrack(QStringLiteral(""));
Settings::Instance().SetAutoUpdateTrack(QString{});
dialog->reject();
});