Misc fixes #100
Misc fixes #100
Conversation
| 0 << 8, // 24 bits | ||
| 2 << 8, // 53 bits | ||
| 3 << 8, // 64 bits | ||
| 3 << 8, // mask |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
There, I also renamed the rounding mode table. |
|
I consider this merge-ready. |
| @@ -134,6 +134,7 @@ static void DSPCore_FreeMemoryPages() | |||
| FreeMemoryPages(g_dsp.iram, DSP_IRAM_BYTE_SIZE); | |||
| FreeMemoryPages(g_dsp.dram, DSP_DRAM_BYTE_SIZE); | |||
| FreeMemoryPages(g_dsp.coef, DSP_COEF_BYTE_SIZE); | |||
| g_dsp.irom = g_dsp.iram = g_dsp.dram = g_dsp.coef = NULL; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Don't merge this yet, I need to rethink TextureConversionShader.cpp |
|
Actually, do merge it like this. While not required, making all related functions in TextureConversionShader.cpp take a pointer reference should be more readable. I think it's worth violating our "const references only" rule here for the time being. |
|
OK, I squashed the fix commit. Ready for merging. |
| @@ -23,8 +23,9 @@ | |||
| #include "Core/HW/WiimoteEmu/Attachment/Turntable.h" | |||
| #include "Core/HW/WiimoteReal/WiimoteReal.h" | |||
|
|
|||
|
|
|||
| #ifdef _WIN32 | |||
| inline double round(double x) { return (x-floor(x))>0.5 ? ceil(x) : floor(x); } //because damn MSVSC doesen't comply to C99 | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
- mostly remove unused variables - rename some generic JIT identifiers
- remove unused variables - reduce the scope where it makes sense - correct limits (did you know that strcat()'s last parameter does not include the \0 that is always added?) - set some free()'d pointers to NULL
1. It's not correct, it rounds x.5 down to x. 2. It is visible across the whole project (!). 3. VS2013 finally supports this: http://msdn.microsoft.com/en-us/library/dn353646.aspx http://msdn.microsoft.com/en-us/library/dn329049.aspx
I compiled Dolphin with clang and went from there.