Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FifoDataFile: Improve error handling when reading #10004

Merged
merged 1 commit into from Aug 7, 2021

Conversation

Pokechu22
Copy link
Contributor

The main thing I'm targeting here is opening a 0-byte file, as currently that produces the nonsensical error message "The DFF's minimum loader version (1) exceeds the version of this FIFO Player (5)" (due to the check on header.fileId != FILE_ID). I often end up opening a 0-byte file if I try to open it while it's still downloading (as firefox creates a 0-byte file as well as a .tmp file).

The other checks were added for completeness; note that Common::IOFile uses RAII so the manual close calls aren't needed. I removed them for Load but haven't touched anything in Save.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@Pokechu22
Copy link
Contributor Author

ss-timestone appears to be corrupt (it has a bad offset for memory updates on the 2nd frame, and the 2nd and 3rd frames in general seem messed up), and has since been disabled on fifo.ci.

@Tilka Tilka merged commit f2a7706 into dolphin-emu:master Aug 7, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants