Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Fix EFB Copy Offset in more games #10005

Merged
merged 1 commit into from Aug 8, 2021

Conversation

JMC47
Copy link
Contributor

@JMC47 JMC47 commented Aug 7, 2021

SpongeBob SquarePants: Battle for Bikini Bottom and The Movie Game, along with the two Incredibles titles suffer from an EFB offset issue described in earlier commits. This commit adds support for the Incredibles 1/2 revisions and adds additional inis for SpongeBob special releases.

To the best of my knowledge, no The Incredibles: Rise of the Underminer GIQP78 exists, but it is marked on our wiki so I added it to the base INI as a possible revision. I did not provide a code for it, though. These probably need a really good look over as this is probably the most changes I've ever packed into a single pull request.

@JosJuice
Copy link
Member

JosJuice commented Aug 7, 2021

To the best of my knowledge, no Incredible 2 GIQP78 exists, but it is marked on our wiki so I added it to the base INI as a possible revision.

In that case, I think it would be better to not list it in the INI. We already have several cases of an INI not listing game IDs that definitely exist, and listing something that doesn't exist can cause confusion in the future. (Right now you're choosing to include this game ID in the INI just based on what the wiki says, and maybe in the future someone else will choose to include the game ID somewhere else based on what the INI and the wiki says...)

@JMC47
Copy link
Contributor Author

JMC47 commented Aug 7, 2021

I removed the GIQP78 mention.

@Tilka
Copy link
Member

Tilka commented Aug 7, 2021

It's still mentioned in the shared ini.

@JMC47
Copy link
Contributor Author

JMC47 commented Aug 7, 2021

I must have removed one of the valid gameids because I'm blind. will fix tomorrow.

@JMC47
Copy link
Contributor Author

JMC47 commented Aug 7, 2021

Actually removed GIQP78 this time around. Corrected Incredibles 2 to The Incredibles: Rise of the Underminer, because that's the actual name and Incredibles 2 is something else.

SpongeBob SquarePants: Battle for Bikini Bottom and The Movie Game,
along with the two Incredibles titles suffer from an EFB offset issue
described in earlier commits.  This commit adds offsets for the
Incredibles and The Incredibles: Rise of the Underminer releases
and adds additional inis for SpongeBob special releases.
@Tilka Tilka merged commit 682c745 into dolphin-emu:master Aug 8, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants