Android: Remove the EmulationState class #10008
Merged
+112
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
android-remove-emulationstate
branch
from
0dd90fe
to
01baa7b
Compare
leoetlino
reviewed
Sep 20, 2021
Fixes a crash which was uncovered (or just made more likely?) by the previous commit.
These methods are only being called from the GUI thread anyway...
The purpose of this class was to keep track of state which the emulation core was already keeping track of. This is rather risky - if we update the state of one of the two without updating the other, the two become out of sync, leading to some rather confusing problems. This duplicated state was removed from EmulationState in the previous commits, so now there isn't much left in the class. Might as well move its members directly into EmulationFragment.
JosJuice
force-pushed
the
android-remove-emulationstate
branch
from
01baa7b
to
53d7d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The purpose of this class is to keep track of state which the emulation core is also keeping track of. This is rather risky – if we update the state of one of the two without updating the other, the two become out of sync, leading to some rather confusing problems. I think we're better off only keeping this state in the emulation core.
In particular, this change fixes a panic alert deadlock when booting a file that isn't a valid GC/Wii file while holding the phone in an orientation which does not match the orientation set in the Dolphin settings.