PowerPC: Minor cleanup around JitCache_TranslateAddress(). #10010
+49
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
jit-cache-translate-address-cleanup
branch
from
2273cf4
to
dba87df
Compare
lioncash
reviewed
Aug 9, 2021
AdmiralCurtiss
force-pushed
the
jit-cache-translate-address-cleanup
branch
from
dba87df
to
ef9a2cb
Compare
lioncash
reviewed
Aug 9, 2021
…he address was translated.
AdmiralCurtiss
force-pushed
the
jit-cache-translate-address-cleanup
branch
from
ef9a2cb
to
116d136
Compare
JosJuice
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The only functional change is around
TranslateResult::from_bat, which was previously true but is now false ifMSR.IRis off... but since no one actually checks that variable at the moment even that doesn't actually change behavior. I'm keeping it around though because I found a use for it in #10007.