Split out code for serializing/deserializing cheat lines #10011
Conversation
JosJuice
force-pushed
the
android-cheats-preparation
branch
from
4a1864d
to
2239331
Compare
JosJuice
force-pushed
the
android-cheats-preparation
branch
from
2239331
to
11c2538
Compare
JosJuice
force-pushed
the
android-cheats-preparation
branch
3 times, most recently
from
366d6c5
to
aa78fc7
Compare
Source/Core/Core/GeckoCodeConfig.cpp
Outdated
|
|
||
| bool DeserializeLine(const std::string& line, GeckoCode::Code* out) | ||
| { | ||
| std::vector<std::string> pieces = SplitString(line, ' '); |
There was a problem hiding this comment.
I'm not sure if this is ever really a problem in practice, but this function has quite different behavior compared to the old ss >> std::hex >> new_code.address >> new_code.data; code. Leading whitespace was previously okay but is now a failure, and any non-space whitespace anywhere near the code parts also no longer works.
If you're okay with breaking behavior anyway I would just go ahead and make this function return std::optional<GeckoCode::Code>. The other code above can just construct its own GeckoCode::Code with just the original_line set in the failure case.
There was a problem hiding this comment.
Hmm... I hadn't thought about that change in behavior. I think it should be fine for INI files (and having Gecko INI parsing be consistent with AR INI parsing is nice), but I'm unsure if the stuff we download from geckocodes.org might contain odd whitespace. However, we're not actually calling this from the geckocodes.org downloading function, so it should be fine.
Good point about how the code above could handle getting an optional. I've made it do that.
JosJuice
force-pushed
the
android-cheats-preparation
branch
from
aa78fc7
to
ceecd4f
Compare
JosJuice
force-pushed
the
android-cheats-preparation
branch
from
ceecd4f
to
b90008a
Compare
Some refactoring to prepare for my upcoming Android cheats PR. I figured it would make sense to submit this as a separate PR, since C++-heavy and Java-heavy PRs tend to get reviewed by different people.