WiimoteReal: Remove WiimoteScannerDarwin #10013
Merged
+0
−447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For several reasons: - It pegs the CPU at 95% for scanning even when Dolphin is idle - WiimoteScannerHidapi works fine on macOS - Less macOS code to maintain
|
Is there maybe some systems/configurations which won't work with hidapi? |
|
hidapi uses the standard macOS IOKit HID APIs which have been basically unchanged in a while, so I don't see a reason why it wouldn't work on some Macs. It should be compatible with at least macOS 10.9 Mavericks given when the version in Externals was last updated (Dolphin requires 10.12 Sierra minimum). I think it should be compatible with all configurations. |
|
Alright. I'm just trying to think of any reason why we were keeping the Darwin code around in the first place. Having 2 functionally similar scanners seems a tad silly. |
lioncash
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Title.
I think this should be done for several reasons:
WiimoteScannerHidapiworks fine on macOS (in fact, in my testing,hidapialways connects a Wiimote first before the Darwin-specific code...)